You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/17 18:48:55 UTC
[GitHub] [pulsar] lhotari opened a new issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
lhotari opened a new issue #10787:
URL: https://github.com/apache/pulsar/issues/10787
<!---
Instructions for reporting a flaky test using this issue template:
1. Replace [test class] in title and body with the test class name
2. Replace [test method] in title and body with the test method that failed. Multiple methods are flaky, remove the content that refers to the test method.
3. Replace "url here" with a url to an example failure. In the Github Actions workflow run logs, you can right click on the line number to copy a link to the line. Example of such url is https://github.com/apache/pulsar/pull/8892/checks?check_run_id=1531075794#step:9:377 . The logs are available for a limited amount of time (usually for a few weeks).
4. Replace "relevant parts of the exception stacktrace here" with the a few lines of the stack trace that shows at leat the exception message and the line of test code where the stacktrace occured.
5. Replace "full exception stacktrace here" with the full exception stacktrace from logs. This section will be hidded by default.
6. Remove all unused fields / content to unclutter the reported issue. Remove this comment too.
-->
MessagePublishBufferThrottleTest is flaky. The testBlockByPublishRateLimiting test method fails sporadically.
[example failure](https://github.com/apache/pulsar/pull/10782/checks?check_run_id=2728428471#step:10:331)
```
testBlockByPublishRateLimiting(org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest) Time elapsed: 0.591 s <<< FAILURE!
java.lang.AssertionError: expected [1] but found [0]
at org.testng.Assert.fail(Assert.java:99)
at org.testng.Assert.failNotEquals(Assert.java:1037)
at org.testng.Assert.assertEqualsImpl(Assert.java:140)
at org.testng.Assert.assertEquals(Assert.java:122)
at org.testng.Assert.assertEquals(Assert.java:797)
at org.testng.Assert.assertEquals(Assert.java:807)
at org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting(MessagePublishBufferThrottleTest.java:129)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
315157973 commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-853570900
I have fixed it and I will open a PR soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-853238981
yet another [example failure](https://github.com/apache/pulsar/pull/9927/checks?check_run_id=2729711384#step:10:712)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-853237392
@Renkai @315157973 Would you be able to fix this flaky test? thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
315157973 commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-853567926
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
eolivelli closed issue #10787:
URL: https://github.com/apache/pulsar/issues/10787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-881942922
This test remains flaky. Recent failure: https://github.com/apache/pulsar/runs/3091955732#step:10:418 .
```
Error: Tests run: 8, Failures: 1, Errors: 0, Skipped: 7, Time elapsed: 14.491 s <<< FAILURE! - in org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest
Error: testBlockByPublishRateLimiting(org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest) Time elapsed: 6.218 s <<< FAILURE!
java.lang.AssertionError: expected [0] but found [1]
at org.testng.Assert.fail(Assert.java:99)
at org.testng.Assert.failNotEquals(Assert.java:1037)
at org.testng.Assert.assertEqualsImpl(Assert.java:140)
at org.testng.Assert.assertEquals(Assert.java:122)
at org.testng.Assert.assertEquals(Assert.java:797)
at org.testng.Assert.assertEquals(Assert.java:807)
at org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting(MessagePublishBufferThrottleTest.java:145)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-884776031
[ another failure](https://github.com/apache/pulsar/runs/3132013580?check_suite_focus=true#step:10:1964)
```
Error: Tests run: 8, Failures: 1, Errors: 0, Skipped: 7, Time elapsed: 14.18 s <<< FAILURE! - in org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest
Error: testBlockByPublishRateLimiting(org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest) Time elapsed: 5.751 s <<< FAILURE!
java.lang.AssertionError: expected [0] but found [1]
at org.testng.Assert.fail(Assert.java:99)
at org.testng.Assert.failNotEquals(Assert.java:1037)
at org.testng.Assert.assertEqualsImpl(Assert.java:140)
at org.testng.Assert.assertEquals(Assert.java:122)
at org.testng.Assert.assertEquals(Assert.java:797)
at org.testng.Assert.assertEquals(Assert.java:807)
at org.apache.pulsar.broker.service.MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting(MessagePublishBufferThrottleTest.java:145)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:829)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
lhotari closed issue #10787:
URL: https://github.com/apache/pulsar/issues/10787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
315157973 commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-853567926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-853239555
and [another failure](https://github.com/apache/pulsar/pull/9927/checks?check_run_id=2729711384#step:10:1059)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
eolivelli closed issue #10787:
URL: https://github.com/apache/pulsar/issues/10787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on issue #10787: Flaky-test: MessagePublishBufferThrottleTest.testBlockByPublishRateLimiting
Posted by GitBox <gi...@apache.org>.
315157973 commented on issue #10787:
URL: https://github.com/apache/pulsar/issues/10787#issuecomment-882081505
Some code has been added to this unit test recently, the reason is the same as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org