[GitHub] [spark] amaliujia commented on a diff in pull request #38984: [SPARK-41349][CONNECT][PYTHON] Implement DataFrame.hint

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38984:
URL: https://github.com/apache/spark/pull/38984#discussion_r1044124554


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -305,7 +305,11 @@ class SparkConnectPlanner(session: SparkSession) {
   }
 
   private def transformHint(rel: proto.Hint): LogicalPlan = {
-    val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq
+    val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq.map{
+      case name: String => UnresolvedAttribute(name)
+      case l: Long => l.toInt

Review Comment:
   I am a bot confused here: why need this convert?



##########
python/pyspark/sql/connect/proto_converter.py:
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+from typing import Any
+
+import decimal
+import datetime
+
+from pyspark.sql.types import TimestampType, DayTimeIntervalType, DateType
+
+import pyspark.sql.connect.proto as proto
+
+
+def to_proto_literal(value: Any) -> "proto.Expression.Literal":
+    """Converts the literal value to the expression in proto.
+
+    TODO(SPARK-40533) This method always assumes the largest type and can thus
+         create weird interpretations of the literal."""
+
+    literal = proto.Expression.Literal()
+    if value is None:
+        literal.null = True
+    elif isinstance(value, (bytes, bytearray)):
+        literal.binary = bytes(value)
+    elif isinstance(value, bool):
+        literal.boolean = bool(value)
+    elif isinstance(value, int):
+        literal.long = int(value)
+    elif isinstance(value, float):
+        literal.double = float(value)
+    elif isinstance(value, str):
+        literal.string = str(value)
+    elif isinstance(value, decimal.Decimal):
+        literal.decimal.value = str(value)
+        literal.decimal.precision = int(decimal.getcontext().prec)
+    elif isinstance(value, datetime.datetime):
+        literal.timestamp = TimestampType().toInternal(value)
+    elif isinstance(value, datetime.date):
+        literal.date = DateType().toInternal(value)
+    elif isinstance(value, datetime.timedelta):
+        interval = DayTimeIntervalType().toInternal(value)
+        assert interval is not None
+        literal.day_time_interval = int(interval)
+    else:
+        return None

Review Comment:
   In fact there is a types.py and we can move proto_converter to types.
   
   And here you can throw exception for no supported type. There are examples in types.py



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org