You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/22 01:13:35 UTC
[GitHub] [flink] becketqin opened a new pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
becketqin opened a new pull request #12286:
URL: https://github.com/apache/flink/pull/12286
## What is the purpose of the change
Before this patch, Kafka brokers in the IT cases are assigned with port from `NetUtils.getAvailablePort()`. This is a little fragile because there is no guarantee that the port will not be recycled and used by someone else when the broker comes up. There was retries added to avoid the case, but we still see `BindExceptions` from time to time.
This patch solve this problem by letting the broker start the listeners with random ports.
## Brief change log
bfc52432ddb2fc1ea708230e23f449be23df0370 Let the broker pick their own random port instead of using `NetUtils.getAvailablePort()`.
## Verifying this change
Run the tests repeatedly in Intellij without seeing `BindException` anymore. Before the patch the exception is likely to be thrown after 10 - 20 runs.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-632424729
@pnowojski Do you have time to take a look? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-632430830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2021",
"triggerID" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bfc52432ddb2fc1ea708230e23f449be23df0370 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-632430830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2021",
"triggerID" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bfc52432ddb2fc1ea708230e23f449be23df0370 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-635891855
@StephanEwen @pnowojski Thanks for the review. I will try to run the test @pnowojski pointed out and see if the patch may cause problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-632425120
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bfc52432ddb2fc1ea708230e23f449be23df0370 (Fri May 22 01:15:19 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-632430830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2021",
"triggerID" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bfc52432ddb2fc1ea708230e23f449be23df0370 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2021)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-632430830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bfc52432ddb2fc1ea708230e23f449be23df0370",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bfc52432ddb2fc1ea708230e23f449be23df0370 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #12286: [FLINK-14592][connector/kafka][test-stability] Use random port for broker creation.
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12286:
URL: https://github.com/apache/flink/pull/12286#issuecomment-633870415
Looks good, thanks a lot!
+1 to merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org