You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/11 13:10:13 UTC

[GitHub] [superset] geido commented on pull request #20728: feat(dashboard): Add Drill to Detail modal w/ chart menu + right-click support

geido commented on PR #20728:
URL: https://github.com/apache/superset/pull/20728#issuecomment-1211968566

   Some more comments from manual testing:
   
   - When resizing the modal, the pagination should stick to the bottom. Also, there are 2 vertical scrolls there. I believe we should only have 1 vertical scroll
   
   ![Screenshot 2022-08-11 at 15 43 48](https://user-images.githubusercontent.com/60598000/184136148-7c9d50bc-ba54-4ee4-8229-9c9ac1459f25.png)
   
   - Let's set a minimum size for the modal as the user should never resize it to the point that is unusable
   
   ![Screenshot 2022-08-11 at 15 47 42](https://user-images.githubusercontent.com/60598000/184136676-67d5f2eb-a412-47d6-98fd-2285f931d006.png)
   
   - When refreshing, should we move the user to page 1? I am thinking of an edge case where we have 2 pages initially, but a bunch of data is deleted or the underlying dataset has changed, now you only have 1 page, but the request will still try to look for page 2 causing a scenario like the one depicted below
   
   ![Screenshot 2022-08-11 at 15 58 27](https://user-images.githubusercontent.com/60598000/184138850-76ab1f19-55ef-42f3-8227-b55ea83f4b9a.png)
   
   - In the example above you can also see some weird layout for the no results which needs improvement
   
   - I think we can consider this problem for a next phase, but I believe the user should be able to select exclusively all the content of the table without selecting any other area of the application
   
   ![Screenshot 2022-08-11 at 15 49 19](https://user-images.githubusercontent.com/60598000/184137017-ef82c9ac-4739-43f5-99c3-b847e8d19199.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org