You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/18 02:10:35 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2863: stdint.h: Use conversion macros for the definition of MIN and MAX constants
xiaoxiang781216 commented on a change in pull request #2863:
URL: https://github.com/apache/incubator-nuttx/pull/2863#discussion_r578075667
##########
File path: include/stdint.h
##########
@@ -41,28 +41,28 @@
/* Limits of exact-width integer types */
-#define INT8_MIN (-INT8_MAX - 1)
-#define INT8_MAX 127
-#define UINT8_MAX 255
+#define INT8_MIN (-INT8_MAX - INT8_C(1))
Review comment:
should we use INT8_C(-INT8_MAX - 1) to avoid the default promotion?
##########
File path: include/stdint.h
##########
@@ -41,28 +41,28 @@
/* Limits of exact-width integer types */
-#define INT8_MIN (-INT8_MAX - 1)
-#define INT8_MAX 127
-#define UINT8_MAX 255
+#define INT8_MIN (-INT8_MAX - INT8_C(1))
+#define INT8_MAX INT8_C(127)
+#define UINT8_MAX UINT8_C(255)
-#define INT16_MIN (-INT16_MAX - 1)
-#define INT16_MAX 32767
-#define UINT16_MAX 65535u
+#define INT16_MIN (-INT16_MAX - INT16_C(1))
Review comment:
ditto
##########
File path: include/stdint.h
##########
@@ -41,28 +41,28 @@
/* Limits of exact-width integer types */
-#define INT8_MIN (-INT8_MAX - 1)
-#define INT8_MAX 127
-#define UINT8_MAX 255
+#define INT8_MIN (-INT8_MAX - INT8_C(1))
+#define INT8_MAX INT8_C(127)
+#define UINT8_MAX UINT8_C(255)
-#define INT16_MIN (-INT16_MAX - 1)
-#define INT16_MAX 32767
-#define UINT16_MAX 65535u
+#define INT16_MIN (-INT16_MAX - INT16_C(1))
+#define INT16_MAX INT16_C(32767)
+#define UINT16_MAX UINT16_C(65535)
#ifdef __INT24_DEFINED
-# define INT24_MIN (-INT24_MAX - 1)
-# define INT24_MAX 8388607
-# define UINT24_MAX 16777215u
+# define INT24_MIN (-INT24_MAX - INT24_C(1))
Review comment:
ditto
##########
File path: include/stdint.h
##########
@@ -41,28 +41,28 @@
/* Limits of exact-width integer types */
-#define INT8_MIN (-INT8_MAX - 1)
-#define INT8_MAX 127
-#define UINT8_MAX 255
+#define INT8_MIN (-INT8_MAX - INT8_C(1))
Review comment:
or INT8_C(-128) directly
##########
File path: include/stdint.h
##########
@@ -41,28 +41,28 @@
/* Limits of exact-width integer types */
-#define INT8_MIN (-INT8_MAX - 1)
-#define INT8_MAX 127
-#define UINT8_MAX 255
+#define INT8_MIN (-INT8_MAX - INT8_C(1))
+#define INT8_MAX INT8_C(127)
+#define UINT8_MAX UINT8_C(255)
-#define INT16_MIN (-INT16_MAX - 1)
-#define INT16_MAX 32767
-#define UINT16_MAX 65535u
+#define INT16_MIN (-INT16_MAX - INT16_C(1))
+#define INT16_MAX INT16_C(32767)
+#define UINT16_MAX UINT16_C(65535)
#ifdef __INT24_DEFINED
-# define INT24_MIN (-INT24_MAX - 1)
-# define INT24_MAX 8388607
-# define UINT24_MAX 16777215u
+# define INT24_MIN (-INT24_MAX - INT24_C(1))
+# define INT24_MAX INT24_C(8388607)
+# define UINT24_MAX UINT24_C(16777215)
#endif
-#define INT32_MIN (-INT32_MAX - 1)
-#define INT32_MAX 2147483647
-#define UINT32_MAX 4294967295u
+#define INT32_MIN (-INT32_MAX - INT32_C(1))
+#define INT32_MAX INT32_C(2147483647)
+#define UINT32_MAX UINT32_C(4294967295)
#ifdef __INT64_DEFINED
-# define INT64_MIN (-INT64_MAX - 1ll)
-# define INT64_MAX 9223372036854775807ll
-# define UINT64_MAX 18446744073709551615ull
+# define INT64_MIN (-INT64_MAX - INT64_C(1))
Review comment:
ditto
##########
File path: include/stdint.h
##########
@@ -41,28 +41,28 @@
/* Limits of exact-width integer types */
-#define INT8_MIN (-INT8_MAX - 1)
-#define INT8_MAX 127
-#define UINT8_MAX 255
+#define INT8_MIN (-INT8_MAX - INT8_C(1))
+#define INT8_MAX INT8_C(127)
+#define UINT8_MAX UINT8_C(255)
-#define INT16_MIN (-INT16_MAX - 1)
-#define INT16_MAX 32767
-#define UINT16_MAX 65535u
+#define INT16_MIN (-INT16_MAX - INT16_C(1))
+#define INT16_MAX INT16_C(32767)
+#define UINT16_MAX UINT16_C(65535)
#ifdef __INT24_DEFINED
-# define INT24_MIN (-INT24_MAX - 1)
-# define INT24_MAX 8388607
-# define UINT24_MAX 16777215u
+# define INT24_MIN (-INT24_MAX - INT24_C(1))
+# define INT24_MAX INT24_C(8388607)
+# define UINT24_MAX UINT24_C(16777215)
#endif
-#define INT32_MIN (-INT32_MAX - 1)
-#define INT32_MAX 2147483647
-#define UINT32_MAX 4294967295u
+#define INT32_MIN (-INT32_MAX - INT32_C(1))
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org