You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/28 02:13:37 UTC
[GitHub] [airflow] mik-laj opened a new pull request #8596: Add Local Filesystem Secret Backend (v1-10)
mik-laj opened a new pull request #8596:
URL: https://github.com/apache/airflow/pull/8596
Backport: https://github.com/apache/airflow/pull/8436
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #8596: Add Local Filesystem Secret Backend (v1-10)
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8596:
URL: https://github.com/apache/airflow/pull/8596#discussion_r416583531
##########
File path: airflow/utils/code_utils.py
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+def prepare_code_snippet(file_path, line_no, context_lines_count=5):
+ """
+ Prepare code snippet with line numbers and a specific line marked.
Review comment:
```suggestion
Prepare code snippet with line numbers and a specific line marked.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #8596: Add Local Filesystem Secret Backend (v1-10)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #8596:
URL: https://github.com/apache/airflow/pull/8596#issuecomment-620911727
@kaxil Github Action is green. Can I ask for review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #8596: Add Local Filesystem Secret Backend (v1-10)
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8596:
URL: https://github.com/apache/airflow/pull/8596#discussion_r416582904
##########
File path: airflow/exceptions.py
##########
@@ -117,3 +121,34 @@ class DagConcurrencyLimitReached(AirflowException):
class TaskConcurrencyLimitReached(AirflowException):
"""Raise when task concurrency limit is reached"""
+
+
+file_syntax_error = namedtuple('FileSyntaxError', 'line_no message')
+"""Information about a single error in a file."""
+
+
+class AirflowFileParseException(AirflowException):
+ """
+ Raises when connection or variable file can not be parsed
+ :param msg: The human-readable description of the exception
Review comment:
```suggestion
Raises when connection or variable file can not be parsed
:param msg: The human-readable description of the exception
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org