[jira] [Comment Edited] (PDFBOX-2427) Make Type1Font non final

["John Hewson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170511#comment-14170511 ] 

John Hewson edited comment on PDFBOX-2427 at 10/14/14 4:38 AM:
---------------------------------------------------------------

This is by design, final classes and final methods are an important mechanism for reducing the surface area of our public API. Instead of creating a mock, bundle a real PFB file with your tests - that way you won't introduce any bugs by making mistakes in your mock implantation.


was (Author: jahewson):
This is by design, final classes and final methods are an important mechanism for reducing the surface area of our public API. Instead of creating a mock, bundle a real PFB file with your tests - that way you won't introduce any bugs my making mistakes in your mock implantation.

> Make Type1Font non final
> ------------------------
>
>                 Key: PDFBOX-2427
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2427
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Cornelis Hoeflake
>
> The Type1Font class is now final. Please make this class non final, for example we could not create a mock instance because it is final.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)