You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/04 20:01:06 UTC

[GitHub] [arrow-rs] alamb commented on issue #2320: optimize the validation of decimal: compare data using the byte array instead of i128 or string

alamb commented on issue #2320:
URL: https://github.com/apache/arrow-rs/issues/2320#issuecomment-1205711020

   I think it is important to:
   1. ensure that some sort of validate is called for every insertion of a decimal value into a Decimal128Array or Decimal256Array
   2. ensure that the validation is only done once per value
   3. Allow some way to skip this validation if the user wishes (e.g. `ArrayData::new_unchecked` https://docs.rs/arrow/19.0.0/arrow/array/struct.ArrayData.html#method.new_unchecked)
   
   Performance wise I haven't checked if we are validating things twice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org