You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ri...@apache.org on 2021/05/20 09:17:35 UTC

[incubator-streampipes] branch dev updated (4f4a4ed -> a3021bb)

This is an automated email from the ASF dual-hosted git repository.

riemer pushed a change to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git.


    from 4f4a4ed  [hotfix] Fix bug causing exception when building pipelines with multiple elements of same type
     new 3dc36f4  [STREAMPIPES-362] Disable preview button for empty pipelines
     new a3021bb  [STREAMPIPES-365] Fix bug in pipeline validation

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../pipeline-assembly/pipeline-assembly.component.html           | 4 ++--
 ui/src/app/editor/components/pipeline/pipeline.component.ts      | 9 ++++++---
 2 files changed, 8 insertions(+), 5 deletions(-)

[incubator-streampipes] 01/02: [STREAMPIPES-362] Disable preview button for empty pipelines

Posted by ri...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

riemer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git

commit 3dc36f49396ebfecf3f24c7f73d9fc111f86e5ed
Author: Dominik Riemer <ri...@fzi.de>
AuthorDate: Thu May 20 10:59:09 2021 +0200

    [STREAMPIPES-362] Disable preview button for empty pipelines
---
 .../components/pipeline-assembly/pipeline-assembly.component.html     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.html b/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.html
index c41b62c..bf42643 100644
--- a/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.html
+++ b/ui/src/app/editor/components/pipeline-assembly/pipeline-assembly.component.html
@@ -23,7 +23,7 @@
                     [disabled]="!PipelineValidationService.pipelineValid"
                     (click)="submit()" type="submit">
                 <div fxLayoutAlign="start center" fxLayout="row">
-                    <i class="material-icons">save</i>&nbsp;
+                    <i class="material-icons">save</i>
                     <span>&nbsp;Save pipeline</span>
                 </div>
             </button>
@@ -40,7 +40,7 @@
 <!--                <i class="material-icons">mode_edit</i>-->
 <!--            </button>-->
             <button mat-button matTooltip="Data Preview" [matTooltipPosition]="'above'"
-                    (click)="triggerPipelinePreview()">
+                    (click)="triggerPipelinePreview()" [disabled]="isPipelineAssemblyEmpty()">
                 <div fxLayoutAlign="start center" fxLayout="row">
                     <i class="material-icons">visibility</i>
                     <span *ngIf="!pipelineComponent.previewModeActive">&nbsp;Enable live preview</span>

[incubator-streampipes] 02/02: [STREAMPIPES-365] Fix bug in pipeline validation

Posted by ri...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

riemer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampipes.git

commit a3021bb8b1e99b805548ae435b61bffc9e218f3a
Author: Dominik Riemer <ri...@fzi.de>
AuthorDate: Thu May 20 11:17:21 2021 +0200

    [STREAMPIPES-365] Fix bug in pipeline validation
---
 ui/src/app/editor/components/pipeline/pipeline.component.ts | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/ui/src/app/editor/components/pipeline/pipeline.component.ts b/ui/src/app/editor/components/pipeline/pipeline.component.ts
index de33c1e..c478963 100644
--- a/ui/src/app/editor/components/pipeline/pipeline.component.ts
+++ b/ui/src/app/editor/components/pipeline/pipeline.component.ts
@@ -136,9 +136,11 @@ export class PipelineComponent implements OnInit, OnDestroy {
   }
 
   validatePipeline() {
-    this.ngZone.run(() => {
-      this.pipelineValid = this.PipelineValidationService
-          .isValidPipeline(this.rawPipelineModel.filter(pe => !(pe.settings.disabled)), this.preview);
+    setTimeout(() => {
+      this.ngZone.run(() => {
+        this.pipelineValid = this.PipelineValidationService
+            .isValidPipeline(this.rawPipelineModel.filter(pe => !(pe.settings.disabled)), this.preview);
+      });
     });
   }
 
@@ -281,6 +283,7 @@ export class PipelineComponent implements OnInit, OnDestroy {
       this.EditorService.makePipelineAssemblyEmpty(true);
     }
     this.JsplumbBridge.repaintEverything();
+    this.validatePipeline();
     this.triggerPipelineCacheUpdate();
   }