You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by John Hjelmstad <fa...@google.com> on 2008/10/23 03:10:57 UTC
Re: bug ? in DefaultContentRewriter - line 110
Viji:
That sounds like precisely the fix that's needed (wrapped in an if-clause:
if (rewrite(.., .., ...)) { content.setContent(new
String(baos.toByteArray())); }
I've committed this fix in r707240.
Thanks for the help!
John
On Wed, Oct 22, 2008 at 5:48 PM, Viji Subramanian <
Viji.Subramanian@corp.aol.com> wrote:
> Louis / Kevin
>
> I think there might be an issue - the mutable content is not set with the
> rewritten content. In DefaultContentRewriter - line 110 - does the rewrite -
> and the content is rewritten to the output stream writer - ie the "output"
> variable.
>
> however, it nevers gets set in the mutable content - mc.
>
> I added content.setContent(new String(baos.toByteArray())); at line 114..
> in my shindig code and it seems to have fixed it..
>
> Louis probably knows the fix better.
>
> Can this be taken care of in 0.8 release ? - we plan to baseline our code
> base with 0.8.
>
> Thanks
>
>
> Viji Subramanian wrote:
>
>> Louis,
>>
>> .prevButton{ background:transparent url(modulet_shared_sprite.gif)
>> no-repeat -0pt -50px; width:20px !important;}
>>
>> It does hit CssRewriter.rewrite(r, source, createLinkRewriter(spec,
>> rewriterFeature), w); - line 176 of DefaultContentRewriter.
>>
>> I do see CssRewriter is calling rewriteLink - line 62 and
>>
>> I see that in ProxyLinkRewriter - line 66 - result variable has
>>
>>
>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2F*modulet_shared_sprite.gif*&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>>
>> But by the time, I reach DefaultContentRewriterRegistry - line 77, i see
>> that the rewrittenContent doesn't have the above rewritten url, it still has
>> url(modulet_shared_sprite.gif)
>>
>> Louis Ryan wrote:
>>
>>> Sorry early-send.
>>>
>>> Can you do a little debugging for this? Specifically check that
>>> CssRewriter.rewrite is calling rewriteLink (line 62) with the expected
>>> content and that its outputting correctly. If you cant please file a JIRA
>>> ticket and include the reproducible sample and Ill take a look.
>>>
>>> Thanks for looking into this.
>>>
>>> On Wed, Oct 22, 2008 at 10:47 AM, Louis Ryan <lr...@google.com> wrote:
>>>
>>>
>>>
>>>> Can you do a little debugging for this. Specifically check that
>>>> CssRewriter.rewriter is calling
>>>>
>>>> On Tue, Oct 21, 2008 at 5:30 PM, Kevin Brown <et...@google.com> wrote:
>>>>
>>>>
>>>>
>>>>> What's the gadget url?
>>>>>
>>>>> The most likely reason for skipping this would be because it's not in
>>>>> the
>>>>> include / exclude list.
>>>>>
>>>>> Louis wrote the link rewriter and has put a lot of work into it, maybe
>>>>> he
>>>>> can shed some light here.
>>>>>
>>>>> On Tue, Oct 21, 2008 at 5:27 PM, Viji Subramanian <
>>>>> Viji.Subramanian@corp.aol.com> wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Kevin
>>>>>>
>>>>>> I checked out the latest shindig code (well.. oct 6th revision)
>>>>>>
>>>>>> I find that the url in CSS are not getting rewritten to absolute paths
>>>>>>
>>>>>>
>>>>> ..
>>>>>
>>>>>
>>>>>> I see that the CssRewriter rewrites the path - but the final
>>>>>>
>>>>>>
>>>>> mutableContent
>>>>>
>>>>>
>>>>>> that I get doesn't have the rewritten path.
>>>>>>
>>>>>> For example .prevButton{ background:transparent *
>>>>>> url(modulet_shared_sprite.gif)* no-repeat -0pt -50px; width:20px
>>>>>> !important;}
>>>>>>
>>>>>> The url above should get rewritten to *url(
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2Fmodulet_shared_sprite.gif&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>>>>>
>>>>>
>>>>>> )
>>>>>> *
>>>>>> When I use firebug to see the css file that the proxy fetches shows,
>>>>>> the
>>>>>> content of the css file shows just url(*modulet_shared_sprite.gif) -*
>>>>>> I
>>>>>> don't see the rewritten path. So when browser fetches this image, it
>>>>>>
>>>>>>
>>>>> fails
>>>>>
>>>>>
>>>>>> with a 404.
>>>>>>
>>>>>> Do u have any idea at the outset as to why the url's are not getting
>>>>>> rewritten correctly ?
>>>>>>
>>>>>> Thanks for your help
>>>>>>
>>>>>> Viji.
>>>>>> *
>>>>>> *
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>
>>
>>
>
Re: bug ? in DefaultContentRewriter - line 110
Posted by Viji Subramanian <Vi...@corp.aol.com>.
no
John Hjelmstad wrote:
> Agreed, this is a stopgap. Viji, have you taken a look at the parser
> based rewriter as yet?
>
> John
>
> On 10/22/08, Kevin Brown <et...@google.com> wrote:
>
>> We really need to get rid of the lexer based implementation entirely to
>> avoid this sort of bug. Maintaining the same code in two places is painful.
>>
>> On Wed, Oct 22, 2008 at 6:13 PM, John Hjelmstad <fa...@google.com> wrote:
>>
>>
>>> PS. I forgot to give you credit in the original revlog, so just edited it.
>>> Sorry for the original omission :)
>>>
>>> On Wed, Oct 22, 2008 at 6:10 PM, John Hjelmstad <fa...@google.com> wrote:
>>>
>>>
>>>> Viji:
>>>> That sounds like precisely the fix that's needed (wrapped in an
>>>>
>>> if-clause:
>>>
>>>> if (rewrite(.., .., ...)) { content.setContent(new
>>>> String(baos.toByteArray())); }
>>>>
>>>> I've committed this fix in r707240.
>>>>
>>>> Thanks for the help!
>>>> John
>>>>
>>>> On Wed, Oct 22, 2008 at 5:48 PM, Viji Subramanian <
>>>> Viji.Subramanian@corp.aol.com> wrote:
>>>>
>>>>
>>>>> Louis / Kevin
>>>>>
>>>>> I think there might be an issue - the mutable content is not set with
>>>>>
>>> the
>>>
>>>>> rewritten content. In DefaultContentRewriter - line 110 - does the
>>>>>
>>> rewrite -
>>>
>>>>> and the content is rewritten to the output stream writer - ie the
>>>>>
>>> "output"
>>>
>>>>> variable.
>>>>>
>>>>> however, it nevers gets set in the mutable content - mc.
>>>>>
>>>>> I added content.setContent(new String(baos.toByteArray())); at line
>>>>>
>>> 114..
>>>
>>>>> in my shindig code and it seems to have fixed it..
>>>>>
>>>>> Louis probably knows the fix better.
>>>>>
>>>>> Can this be taken care of in 0.8 release ? - we plan to baseline our
>>>>>
>>> code
>>>
>>>>> base with 0.8.
>>>>>
>>>>> Thanks
>>>>>
>>>>>
>>>>> Viji Subramanian wrote:
>>>>>
>>>>>
>>>>>> Louis,
>>>>>>
>>>>>> .prevButton{ background:transparent url(modulet_shared_sprite.gif)
>>>>>> no-repeat -0pt -50px; width:20px !important;}
>>>>>>
>>>>>> It does hit CssRewriter.rewrite(r, source, createLinkRewriter(spec,
>>>>>> rewriterFeature), w); - line 176 of DefaultContentRewriter.
>>>>>>
>>>>>> I do see CssRewriter is calling rewriteLink - line 62 and
>>>>>>
>>>>>> I see that in ProxyLinkRewriter - line 66 - result variable has
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2F*modulet_shared_sprite.gif*&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>>>
>>>>>> But by the time, I reach DefaultContentRewriterRegistry - line 77, i
>>>>>>
>>> see
>>>
>>>>>> that the rewrittenContent doesn't have the above rewritten url, it
>>>>>>
>>> still has
>>>
>>>>>> url(modulet_shared_sprite.gif)
>>>>>>
>>>>>> Louis Ryan wrote:
>>>>>>
>>>>>>
>>>>>>> Sorry early-send.
>>>>>>>
>>>>>>> Can you do a little debugging for this? Specifically check that
>>>>>>> CssRewriter.rewrite is calling rewriteLink (line 62) with the
>>>>>>> expected
>>>>>>> content and that its outputting correctly. If you cant please file a
>>>>>>> JIRA
>>>>>>> ticket and include the reproducible sample and Ill take a look.
>>>>>>>
>>>>>>> Thanks for looking into this.
>>>>>>>
>>>>>>> On Wed, Oct 22, 2008 at 10:47 AM, Louis Ryan <lr...@google.com>
>>>>>>>
>>> wrote:
>>>
>>>>>>>
>>>>>>>
>>>>>>>> Can you do a little debugging for this. Specifically check that
>>>>>>>> CssRewriter.rewriter is calling
>>>>>>>>
>>>>>>>> On Tue, Oct 21, 2008 at 5:30 PM, Kevin Brown <et...@google.com>
>>>>>>>>
>>> wrote:
>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> What's the gadget url?
>>>>>>>>>
>>>>>>>>> The most likely reason for skipping this would be because it's not
>>>>>>>>>
>>> in
>>>
>>>>>>>>> the
>>>>>>>>> include / exclude list.
>>>>>>>>>
>>>>>>>>> Louis wrote the link rewriter and has put a lot of work into it,
>>>>>>>>>
>>> maybe
>>>
>>>>>>>>> he
>>>>>>>>> can shed some light here.
>>>>>>>>>
>>>>>>>>> On Tue, Oct 21, 2008 at 5:27 PM, Viji Subramanian <
>>>>>>>>> Viji.Subramanian@corp.aol.com> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Kevin
>>>>>>>>>>
>>>>>>>>>> I checked out the latest shindig code (well.. oct 6th revision)
>>>>>>>>>>
>>>>>>>>>> I find that the url in CSS are not getting rewritten to absolute
>>>>>>>>>> paths
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> ..
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I see that the CssRewriter rewrites the path - but the final
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> mutableContent
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> that I get doesn't have the rewritten path.
>>>>>>>>>>
>>>>>>>>>> For example .prevButton{ background:transparent *
>>>>>>>>>> url(modulet_shared_sprite.gif)* no-repeat -0pt -50px; width:20px
>>>>>>>>>> !important;}
>>>>>>>>>>
>>>>>>>>>> The url above should get rewritten to *url(
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2Fmodulet_shared_sprite.gif&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>>>
>>>>>>>>>
>>>>>>>>>> )
>>>>>>>>>> *
>>>>>>>>>> When I use firebug to see the css file that the proxy fetches
>>>>>>>>>>
>>> shows,
>>>
>>>>>>>>>> the
>>>>>>>>>> content of the css file shows just url(*modulet_shared_sprite.gif)
>>>>>>>>>> -* I
>>>>>>>>>> don't see the rewritten path. So when browser fetches this image,
>>>>>>>>>> it
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> fails
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> with a 404.
>>>>>>>>>>
>>>>>>>>>> Do u have any idea at the outset as to why the url's are not
>>>>>>>>>>
>>> getting
>>>
>>>>>>>>>> rewritten correctly ?
>>>>>>>>>>
>>>>>>>>>> Thanks for your help
>>>>>>>>>>
>>>>>>>>>> Viji.
>>>>>>>>>> *
>>>>>>>>>> *
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>
>
Re: bug ? in DefaultContentRewriter - line 110
Posted by John Hjelmstad <fa...@google.com>.
Agreed, this is a stopgap. Viji, have you taken a look at the parser
based rewriter as yet?
John
On 10/22/08, Kevin Brown <et...@google.com> wrote:
> We really need to get rid of the lexer based implementation entirely to
> avoid this sort of bug. Maintaining the same code in two places is painful.
>
> On Wed, Oct 22, 2008 at 6:13 PM, John Hjelmstad <fa...@google.com> wrote:
>
>> PS. I forgot to give you credit in the original revlog, so just edited it.
>> Sorry for the original omission :)
>>
>> On Wed, Oct 22, 2008 at 6:10 PM, John Hjelmstad <fa...@google.com> wrote:
>>
>> > Viji:
>> > That sounds like precisely the fix that's needed (wrapped in an
>> if-clause:
>> > if (rewrite(.., .., ...)) { content.setContent(new
>> > String(baos.toByteArray())); }
>> >
>> > I've committed this fix in r707240.
>> >
>> > Thanks for the help!
>> > John
>> >
>> > On Wed, Oct 22, 2008 at 5:48 PM, Viji Subramanian <
>> > Viji.Subramanian@corp.aol.com> wrote:
>> >
>> >> Louis / Kevin
>> >>
>> >> I think there might be an issue - the mutable content is not set with
>> the
>> >> rewritten content. In DefaultContentRewriter - line 110 - does the
>> rewrite -
>> >> and the content is rewritten to the output stream writer - ie the
>> "output"
>> >> variable.
>> >>
>> >> however, it nevers gets set in the mutable content - mc.
>> >>
>> >> I added content.setContent(new String(baos.toByteArray())); at line
>> 114..
>> >> in my shindig code and it seems to have fixed it..
>> >>
>> >> Louis probably knows the fix better.
>> >>
>> >> Can this be taken care of in 0.8 release ? - we plan to baseline our
>> code
>> >> base with 0.8.
>> >>
>> >> Thanks
>> >>
>> >>
>> >> Viji Subramanian wrote:
>> >>
>> >>> Louis,
>> >>>
>> >>> .prevButton{ background:transparent url(modulet_shared_sprite.gif)
>> >>> no-repeat -0pt -50px; width:20px !important;}
>> >>>
>> >>> It does hit CssRewriter.rewrite(r, source, createLinkRewriter(spec,
>> >>> rewriterFeature), w); - line 176 of DefaultContentRewriter.
>> >>>
>> >>> I do see CssRewriter is calling rewriteLink - line 62 and
>> >>>
>> >>> I see that in ProxyLinkRewriter - line 66 - result variable has
>> >>>
>> >>>
>> >>>
>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2F*modulet_shared_sprite.gif*&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>> >>>
>> >>> But by the time, I reach DefaultContentRewriterRegistry - line 77, i
>> see
>> >>> that the rewrittenContent doesn't have the above rewritten url, it
>> still has
>> >>> url(modulet_shared_sprite.gif)
>> >>>
>> >>> Louis Ryan wrote:
>> >>>
>> >>>> Sorry early-send.
>> >>>>
>> >>>> Can you do a little debugging for this? Specifically check that
>> >>>> CssRewriter.rewrite is calling rewriteLink (line 62) with the
>> >>>> expected
>> >>>> content and that its outputting correctly. If you cant please file a
>> >>>> JIRA
>> >>>> ticket and include the reproducible sample and Ill take a look.
>> >>>>
>> >>>> Thanks for looking into this.
>> >>>>
>> >>>> On Wed, Oct 22, 2008 at 10:47 AM, Louis Ryan <lr...@google.com>
>> wrote:
>> >>>>
>> >>>>
>> >>>>
>> >>>>> Can you do a little debugging for this. Specifically check that
>> >>>>> CssRewriter.rewriter is calling
>> >>>>>
>> >>>>> On Tue, Oct 21, 2008 at 5:30 PM, Kevin Brown <et...@google.com>
>> wrote:
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>>> What's the gadget url?
>> >>>>>>
>> >>>>>> The most likely reason for skipping this would be because it's not
>> in
>> >>>>>> the
>> >>>>>> include / exclude list.
>> >>>>>>
>> >>>>>> Louis wrote the link rewriter and has put a lot of work into it,
>> maybe
>> >>>>>> he
>> >>>>>> can shed some light here.
>> >>>>>>
>> >>>>>> On Tue, Oct 21, 2008 at 5:27 PM, Viji Subramanian <
>> >>>>>> Viji.Subramanian@corp.aol.com> wrote:
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>> Kevin
>> >>>>>>>
>> >>>>>>> I checked out the latest shindig code (well.. oct 6th revision)
>> >>>>>>>
>> >>>>>>> I find that the url in CSS are not getting rewritten to absolute
>> >>>>>>> paths
>> >>>>>>>
>> >>>>>>>
>> >>>>>> ..
>> >>>>>>
>> >>>>>>
>> >>>>>>> I see that the CssRewriter rewrites the path - but the final
>> >>>>>>>
>> >>>>>>>
>> >>>>>> mutableContent
>> >>>>>>
>> >>>>>>
>> >>>>>>> that I get doesn't have the rewritten path.
>> >>>>>>>
>> >>>>>>> For example .prevButton{ background:transparent *
>> >>>>>>> url(modulet_shared_sprite.gif)* no-repeat -0pt -50px; width:20px
>> >>>>>>> !important;}
>> >>>>>>>
>> >>>>>>> The url above should get rewritten to *url(
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> >>>>>>
>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2Fmodulet_shared_sprite.gif&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>> >>>>>>
>> >>>>>>
>> >>>>>>> )
>> >>>>>>> *
>> >>>>>>> When I use firebug to see the css file that the proxy fetches
>> shows,
>> >>>>>>> the
>> >>>>>>> content of the css file shows just url(*modulet_shared_sprite.gif)
>> >>>>>>> -* I
>> >>>>>>> don't see the rewritten path. So when browser fetches this image,
>> >>>>>>> it
>> >>>>>>>
>> >>>>>>>
>> >>>>>> fails
>> >>>>>>
>> >>>>>>
>> >>>>>>> with a 404.
>> >>>>>>>
>> >>>>>>> Do u have any idea at the outset as to why the url's are not
>> getting
>> >>>>>>> rewritten correctly ?
>> >>>>>>>
>> >>>>>>> Thanks for your help
>> >>>>>>>
>> >>>>>>> Viji.
>> >>>>>>> *
>> >>>>>>> *
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> >>>>>
>> >>>>
>> >>>>
>> >>>>
>> >>>
>> >>>
>> >>>
>> >>
>> >
>>
>
Re: bug ? in DefaultContentRewriter - line 110
Posted by Kevin Brown <et...@google.com>.
We really need to get rid of the lexer based implementation entirely to
avoid this sort of bug. Maintaining the same code in two places is painful.
On Wed, Oct 22, 2008 at 6:13 PM, John Hjelmstad <fa...@google.com> wrote:
> PS. I forgot to give you credit in the original revlog, so just edited it.
> Sorry for the original omission :)
>
> On Wed, Oct 22, 2008 at 6:10 PM, John Hjelmstad <fa...@google.com> wrote:
>
> > Viji:
> > That sounds like precisely the fix that's needed (wrapped in an
> if-clause:
> > if (rewrite(.., .., ...)) { content.setContent(new
> > String(baos.toByteArray())); }
> >
> > I've committed this fix in r707240.
> >
> > Thanks for the help!
> > John
> >
> > On Wed, Oct 22, 2008 at 5:48 PM, Viji Subramanian <
> > Viji.Subramanian@corp.aol.com> wrote:
> >
> >> Louis / Kevin
> >>
> >> I think there might be an issue - the mutable content is not set with
> the
> >> rewritten content. In DefaultContentRewriter - line 110 - does the
> rewrite -
> >> and the content is rewritten to the output stream writer - ie the
> "output"
> >> variable.
> >>
> >> however, it nevers gets set in the mutable content - mc.
> >>
> >> I added content.setContent(new String(baos.toByteArray())); at line
> 114..
> >> in my shindig code and it seems to have fixed it..
> >>
> >> Louis probably knows the fix better.
> >>
> >> Can this be taken care of in 0.8 release ? - we plan to baseline our
> code
> >> base with 0.8.
> >>
> >> Thanks
> >>
> >>
> >> Viji Subramanian wrote:
> >>
> >>> Louis,
> >>>
> >>> .prevButton{ background:transparent url(modulet_shared_sprite.gif)
> >>> no-repeat -0pt -50px; width:20px !important;}
> >>>
> >>> It does hit CssRewriter.rewrite(r, source, createLinkRewriter(spec,
> >>> rewriterFeature), w); - line 176 of DefaultContentRewriter.
> >>>
> >>> I do see CssRewriter is calling rewriteLink - line 62 and
> >>>
> >>> I see that in ProxyLinkRewriter - line 66 - result variable has
> >>>
> >>>
> >>>
> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2F*modulet_shared_sprite.gif*&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
> >>>
> >>> But by the time, I reach DefaultContentRewriterRegistry - line 77, i
> see
> >>> that the rewrittenContent doesn't have the above rewritten url, it
> still has
> >>> url(modulet_shared_sprite.gif)
> >>>
> >>> Louis Ryan wrote:
> >>>
> >>>> Sorry early-send.
> >>>>
> >>>> Can you do a little debugging for this? Specifically check that
> >>>> CssRewriter.rewrite is calling rewriteLink (line 62) with the expected
> >>>> content and that its outputting correctly. If you cant please file a
> >>>> JIRA
> >>>> ticket and include the reproducible sample and Ill take a look.
> >>>>
> >>>> Thanks for looking into this.
> >>>>
> >>>> On Wed, Oct 22, 2008 at 10:47 AM, Louis Ryan <lr...@google.com>
> wrote:
> >>>>
> >>>>
> >>>>
> >>>>> Can you do a little debugging for this. Specifically check that
> >>>>> CssRewriter.rewriter is calling
> >>>>>
> >>>>> On Tue, Oct 21, 2008 at 5:30 PM, Kevin Brown <et...@google.com>
> wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>>> What's the gadget url?
> >>>>>>
> >>>>>> The most likely reason for skipping this would be because it's not
> in
> >>>>>> the
> >>>>>> include / exclude list.
> >>>>>>
> >>>>>> Louis wrote the link rewriter and has put a lot of work into it,
> maybe
> >>>>>> he
> >>>>>> can shed some light here.
> >>>>>>
> >>>>>> On Tue, Oct 21, 2008 at 5:27 PM, Viji Subramanian <
> >>>>>> Viji.Subramanian@corp.aol.com> wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> Kevin
> >>>>>>>
> >>>>>>> I checked out the latest shindig code (well.. oct 6th revision)
> >>>>>>>
> >>>>>>> I find that the url in CSS are not getting rewritten to absolute
> >>>>>>> paths
> >>>>>>>
> >>>>>>>
> >>>>>> ..
> >>>>>>
> >>>>>>
> >>>>>>> I see that the CssRewriter rewrites the path - but the final
> >>>>>>>
> >>>>>>>
> >>>>>> mutableContent
> >>>>>>
> >>>>>>
> >>>>>>> that I get doesn't have the rewritten path.
> >>>>>>>
> >>>>>>> For example .prevButton{ background:transparent *
> >>>>>>> url(modulet_shared_sprite.gif)* no-repeat -0pt -50px; width:20px
> >>>>>>> !important;}
> >>>>>>>
> >>>>>>> The url above should get rewritten to *url(
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>>
> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2Fmodulet_shared_sprite.gif&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
> >>>>>>
> >>>>>>
> >>>>>>> )
> >>>>>>> *
> >>>>>>> When I use firebug to see the css file that the proxy fetches
> shows,
> >>>>>>> the
> >>>>>>> content of the css file shows just url(*modulet_shared_sprite.gif)
> >>>>>>> -* I
> >>>>>>> don't see the rewritten path. So when browser fetches this image,
> >>>>>>> it
> >>>>>>>
> >>>>>>>
> >>>>>> fails
> >>>>>>
> >>>>>>
> >>>>>>> with a 404.
> >>>>>>>
> >>>>>>> Do u have any idea at the outset as to why the url's are not
> getting
> >>>>>>> rewritten correctly ?
> >>>>>>>
> >>>>>>> Thanks for your help
> >>>>>>>
> >>>>>>> Viji.
> >>>>>>> *
> >>>>>>> *
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >>
> >
>
Re: bug ? in DefaultContentRewriter - line 110
Posted by John Hjelmstad <fa...@google.com>.
PS. I forgot to give you credit in the original revlog, so just edited it.
Sorry for the original omission :)
On Wed, Oct 22, 2008 at 6:10 PM, John Hjelmstad <fa...@google.com> wrote:
> Viji:
> That sounds like precisely the fix that's needed (wrapped in an if-clause:
> if (rewrite(.., .., ...)) { content.setContent(new
> String(baos.toByteArray())); }
>
> I've committed this fix in r707240.
>
> Thanks for the help!
> John
>
> On Wed, Oct 22, 2008 at 5:48 PM, Viji Subramanian <
> Viji.Subramanian@corp.aol.com> wrote:
>
>> Louis / Kevin
>>
>> I think there might be an issue - the mutable content is not set with the
>> rewritten content. In DefaultContentRewriter - line 110 - does the rewrite -
>> and the content is rewritten to the output stream writer - ie the "output"
>> variable.
>>
>> however, it nevers gets set in the mutable content - mc.
>>
>> I added content.setContent(new String(baos.toByteArray())); at line 114..
>> in my shindig code and it seems to have fixed it..
>>
>> Louis probably knows the fix better.
>>
>> Can this be taken care of in 0.8 release ? - we plan to baseline our code
>> base with 0.8.
>>
>> Thanks
>>
>>
>> Viji Subramanian wrote:
>>
>>> Louis,
>>>
>>> .prevButton{ background:transparent url(modulet_shared_sprite.gif)
>>> no-repeat -0pt -50px; width:20px !important;}
>>>
>>> It does hit CssRewriter.rewrite(r, source, createLinkRewriter(spec,
>>> rewriterFeature), w); - line 176 of DefaultContentRewriter.
>>>
>>> I do see CssRewriter is calling rewriteLink - line 62 and
>>>
>>> I see that in ProxyLinkRewriter - line 66 - result variable has
>>>
>>>
>>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2F*modulet_shared_sprite.gif*&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>>>
>>> But by the time, I reach DefaultContentRewriterRegistry - line 77, i see
>>> that the rewrittenContent doesn't have the above rewritten url, it still has
>>> url(modulet_shared_sprite.gif)
>>>
>>> Louis Ryan wrote:
>>>
>>>> Sorry early-send.
>>>>
>>>> Can you do a little debugging for this? Specifically check that
>>>> CssRewriter.rewrite is calling rewriteLink (line 62) with the expected
>>>> content and that its outputting correctly. If you cant please file a
>>>> JIRA
>>>> ticket and include the reproducible sample and Ill take a look.
>>>>
>>>> Thanks for looking into this.
>>>>
>>>> On Wed, Oct 22, 2008 at 10:47 AM, Louis Ryan <lr...@google.com> wrote:
>>>>
>>>>
>>>>
>>>>> Can you do a little debugging for this. Specifically check that
>>>>> CssRewriter.rewriter is calling
>>>>>
>>>>> On Tue, Oct 21, 2008 at 5:30 PM, Kevin Brown <et...@google.com> wrote:
>>>>>
>>>>>
>>>>>
>>>>>> What's the gadget url?
>>>>>>
>>>>>> The most likely reason for skipping this would be because it's not in
>>>>>> the
>>>>>> include / exclude list.
>>>>>>
>>>>>> Louis wrote the link rewriter and has put a lot of work into it, maybe
>>>>>> he
>>>>>> can shed some light here.
>>>>>>
>>>>>> On Tue, Oct 21, 2008 at 5:27 PM, Viji Subramanian <
>>>>>> Viji.Subramanian@corp.aol.com> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Kevin
>>>>>>>
>>>>>>> I checked out the latest shindig code (well.. oct 6th revision)
>>>>>>>
>>>>>>> I find that the url in CSS are not getting rewritten to absolute
>>>>>>> paths
>>>>>>>
>>>>>>>
>>>>>> ..
>>>>>>
>>>>>>
>>>>>>> I see that the CssRewriter rewrites the path - but the final
>>>>>>>
>>>>>>>
>>>>>> mutableContent
>>>>>>
>>>>>>
>>>>>>> that I get doesn't have the rewritten path.
>>>>>>>
>>>>>>> For example .prevButton{ background:transparent *
>>>>>>> url(modulet_shared_sprite.gif)* no-repeat -0pt -50px; width:20px
>>>>>>> !important;}
>>>>>>>
>>>>>>> The url above should get rewritten to *url(
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> http://vijis.jgc.aol.com/gadgets/proxy?url=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2Fmodulet_shared_sprite.gif&gadget=http%3A%2F%2Fstartpagedev-03.my.aol.com%2Fgd%2FdynamicLead%2FdynamicLead.xml&fp=-182800334&refresh=86400
>>>>>>
>>>>>>
>>>>>>> )
>>>>>>> *
>>>>>>> When I use firebug to see the css file that the proxy fetches shows,
>>>>>>> the
>>>>>>> content of the css file shows just url(*modulet_shared_sprite.gif)
>>>>>>> -* I
>>>>>>> don't see the rewritten path. So when browser fetches this image,
>>>>>>> it
>>>>>>>
>>>>>>>
>>>>>> fails
>>>>>>
>>>>>>
>>>>>>> with a 404.
>>>>>>>
>>>>>>> Do u have any idea at the outset as to why the url's are not getting
>>>>>>> rewritten correctly ?
>>>>>>>
>>>>>>> Thanks for your help
>>>>>>>
>>>>>>> Viji.
>>>>>>> *
>>>>>>> *
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>