You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/03/02 11:44:39 UTC

[GitHub] [hudi] mapleFU opened a new pull request, #8084: [HUDI-5870] Fix some comments about column type change rules

mapleFU opened a new pull request, #8084:
URL: https://github.com/apache/hudi/pull/8084

   ### Change Logs
   
   This patch didn't change any logic. It just update the comment for schema evolution type change.
   
   ### Impact
   
   No
   
   ### Risk level (write none, low medium or high below)
   
   No Risk
   
   ### Documentation Update
   
   No document update, these rules are listed here: https://hudi.apache.org/docs/schema_evolution/ . 
   But in the code, these were wrong.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1451797979

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1ddf2e9d22907e27807e0a0487eeee032b2126a0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15536",
       "triggerID" : "1ddf2e9d22907e27807e0a0487eeee032b2126a0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ddf2e9d22907e27807e0a0487eeee032b2126a0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15536) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] mapleFU commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1457449566

   Sorry for creating a issue for that, I'll notice that in the future


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1451986035

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1ddf2e9d22907e27807e0a0487eeee032b2126a0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15536",
       "triggerID" : "1ddf2e9d22907e27807e0a0487eeee032b2126a0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ddf2e9d22907e27807e0a0487eeee032b2126a0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15536) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "xiarixiaoyao (via GitHub)" <gi...@apache.org>.
xiarixiaoyao commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1455963766

   > Hi, would you mind merge this patch? @xiarixiaoyao Or I should wait for other committer / PMC to re-approve this patch?
   
   Sorry for the delay


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1457439519

   @xiarixiaoyao @mapleFU I totally understand this is a minor fix, but can we follow the commit message naming convention like `[MINOR] ${your commit message}`.
   
   Thanks for the contribution BTW.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1451746802

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1ddf2e9d22907e27807e0a0487eeee032b2126a0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1ddf2e9d22907e27807e0a0487eeee032b2126a0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ddf2e9d22907e27807e0a0487eeee032b2126a0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "xiarixiaoyao (via GitHub)" <gi...@apache.org>.
xiarixiaoyao commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1457512110

   @mapleFU @danny0405 
   sorry，This is my fault， will pay attention to these later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao merged pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "xiarixiaoyao (via GitHub)" <gi...@apache.org>.
xiarixiaoyao merged PR #8084:
URL: https://github.com/apache/hudi/pull/8084


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] mapleFU commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1453128238

   Hi, would you mind merge this patch? @xiarixiaoyao
   Or I should wait for other committer / PMC to re-approve this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xiarixiaoyao commented on pull request #8084: [HUDI-5870] Fix some comments about column type change rules

Posted by "xiarixiaoyao (via GitHub)" <gi...@apache.org>.
xiarixiaoyao commented on PR #8084:
URL: https://github.com/apache/hudi/pull/8084#issuecomment-1452807905

   @mapleFU 
   Thank you for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org