You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/20 13:00:25 UTC
[GitHub] [incubator-nuttx] ghn-certi opened a new pull request #1614: tools/configure.sh: Fix order of evaluation of enforce option
ghn-certi opened a new pull request #1614:
URL: https://github.com/apache/incubator-nuttx/pull/1614
## Summary
According to the usage documentation, [-e] option should "enforce
distclean if already configured". This behavior was broken due to the -e
option being evaluated only if the current defconfig is different from
the backup defconfig.
## Impact
The configure.sh script will finally enforce the distclean process regardless of the current state of the defconfig file.
No impact if the user does not rely on the [-e] option.
## Testing
Validated the 3 possible paths:
* ./tools/configure.sh with -e
* ./tools/configure.sh after a modification to the defconfig file
* ./tools/configure.sh without any modification to the defconfig file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1614: tools/configure.sh: Fix order of evaluation of enforce option
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1614:
URL: https://github.com/apache/incubator-nuttx/pull/1614#issuecomment-677659453
Should we change the document like this instead?
"enforce distclean if configuration change"
Our build script always interact with the build system like this:
```
./configure.sh -e chip:config
./make -jx
```
but we don't want to do the full build if there isn't configuration change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1614: tools/configure.sh: Fix order of evaluation of enforce option
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1614:
URL: https://github.com/apache/incubator-nuttx/pull/1614#issuecomment-677662029
I was thinking about this too but wanted to introduce a new option, maybe -E and keep -e as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ghn-certi commented on pull request #1614: tools/configure.sh: Fix order of evaluation of enforce option
Posted by GitBox <gi...@apache.org>.
ghn-certi commented on pull request #1614:
URL: https://github.com/apache/incubator-nuttx/pull/1614#issuecomment-677675722
> -E/-e is a good idea.
I've updated the PR.
Created a new command [-E] for the enforcement behavior.
Changed the documentation of [-e] to consider the distclean operation only if configration changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1614: tools/configure.sh: Fix order of evaluation of enforce option
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1614:
URL: https://github.com/apache/incubator-nuttx/pull/1614#issuecomment-677704294
LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1614: tools/configure.sh: Fix order of evaluation of enforce option
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1614:
URL: https://github.com/apache/incubator-nuttx/pull/1614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1614: tools/configure.sh: Fix order of evaluation of enforce option
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1614:
URL: https://github.com/apache/incubator-nuttx/pull/1614#issuecomment-677664019
-E/-e is a good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org