You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2020/01/06 18:16:48 UTC
Votes by end of week?
Hi all,
It would be good to get votes started on new 3.3 + 3.2 releases by the end
of this week, as we are already overdue. We already have 32 JIRAs fixed for
3.3.5, so it's shaping up to be a pretty big release!
There are 2 remaining JIRA issues targetted for 3.3.5, both assigned to
Freeman. @Freeman Fang <fr...@gmail.com> do you think you have time
to look at them? Otherwise they can be moved to 3.3.6.
On my todo list is:
- Merge https://github.com/apache/cxf/pull/615
- Update XML Schema (currently under vote)
- Merge a fix for the regression introduced by CXF-8088.
Colm.
Re: Votes by end of week?
Posted by Andriy Redko <dr...@gmail.com>.
Sound the idea, thanks Colm! I will try to fix one JMS test which became flaky recently (org.apache.cxf.transport.jms.util.MessageListenerTest.testLocalTransaction), I am aware
of the change in question. Thanks!
Best Regards,
Andriy Redko
Monday, January 6, 2020, 1:16:48 PM, you wrote:
COh> Hi all,
COh> It would be good to get votes started on new 3.3 + 3.2 releases by the end
COh> of this week, as we are already overdue. We already have 32 JIRAs fixed for
COh> 3.3.5, so it's shaping up to be a pretty big release!
COh> There are 2 remaining JIRA issues targetted for 3.3.5, both assigned to
COh> Freeman. @Freeman Fang <fr...@gmail.com> do you think you have time
COh> to look at them? Otherwise they can be moved to 3.3.6.
COh> On my todo list is:
COh> - Merge https://github.com/apache/cxf/pull/615
COh> - Update XML Schema (currently under vote)
COh> - Merge a fix for the regression introduced by CXF-8088.
COh> Colm.
Re: Votes by end of week?
Posted by Andy McCright <j....@gmail.com>.
That sounds good. In that case, let's go ahead and plan to merge the TCK
formparam fix (following Colm's review). If we get the other two reviewed
(and possibly changed) by the end of the week, let's take them too, but no
worries if not.
Thanks!
Andy
On Wed, Jan 8, 2020 at 11:57 AM Andrey Redko <dr...@gmail.com> wrote:
> Hey Andy,
>
> I would finish up with SSE today, I was reading through the callback
> discussion threads you mentioned, we may need to change a few things before
> merge. The TCK formparam fixes look good to me, but I haven't dug into the
> cause to be honest, Colm if you could take a look would be awesome, +1 from
> me to merge. For CDI one I would appreciate to have some time to finish the
> review, thanks!
>
> Best Regards,
> Andriy Redko
>
> On Wed, Jan 8, 2020, 12:35 PM Colm O hEigeartaigh <co...@apache.org>
> wrote:
>
>> No objections from me for including them, if Andriy is happy with them.
>> Otherwise we can leave them for 3.3.6.
>>
>> Colm.
>>
>> On Wed, Jan 8, 2020 at 5:19 PM Andy McCright <j....@gmail.com>
>> wrote:
>>
>>> Andriy, Colm,
>>>
>>> I've three pull requests in progress that we could pull in - I'd like to
>>> get some more reviews on them, but otherwise I think they are ready to
>>> merge. That said, I'm fine with waiting until the next release too. The
>>> PRs in question are:
>>> https://github.com/apache/cxf/pull/619 - Adding injection into MP Rest
>>> Client's ClientHeadersFactory - this will be part of the next MP spec (not
>>> yet released), thus no urgency, but still a nice feature.
>>> https://github.com/apache/cxf/pull/621 - fixes some Jakarta EE JAX-RS
>>> TCK failures in the SSE bucket.
>>> https://github.com/apache/cxf/pull/620 - fixes some Jakarta EE JAX-RS
>>> TCK failures related to FormParam processing.
>>>
>>> Do you want to include them in the 3.3.5?
>>>
>>> Thanks, Andy
>>>
>>> On Wed, Jan 8, 2020 at 9:49 AM Colm O hEigeartaigh <co...@apache.org>
>>> wrote:
>>>
>>>> OK thanks Freeman. As of this point I'm all done with the release.
>>>> @Andriy
>>>> Redko <dr...@gmail.com> please reply when you're finished with any
>>>> changes
>>>> and we can start the votes.
>>>>
>>>> Colm.
>>>>
>>>> On Wed, Jan 8, 2020 at 3:00 PM ffang <fr...@gmail.com> wrote:
>>>>
>>>> >
>>>> >
>>>> > > On Jan 6, 2020, at 1:16 PM, Colm O hEigeartaigh <
>>>> coheigea@apache.org>
>>>> > wrote:
>>>> > >
>>>> > > Hi all,
>>>> > >
>>>> > > It would be good to get votes started on new 3.3 + 3.2 releases by
>>>> the
>>>> > end of this week, as we are already overdue. We already have 32 JIRAs
>>>> fixed
>>>> > for 3.3.5, so it's shaping up to be a pretty big release!
>>>> > >
>>>> > > There are 2 remaining JIRA issues targetted for 3.3.5, both
>>>> assigned to
>>>> > Freeman. @Freeman Fang <ma...@gmail.com> do you think
>>>> you
>>>> > have time to look at them? Otherwise they can be moved to 3.3.6.
>>>> > Hi Colm,
>>>> >
>>>> > Both CXF-8173 and CXF-8183 are same issue, they are harmless in terms
>>>> of
>>>> > function at this stage and we can revisit in the future.
>>>> > Btw, I added comment here to explain it a bit
>>>> >
>>>> >
>>>> >
>>>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
>>>> > <
>>>> >
>>>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
>>>> > >
>>>> >
>>>> > Best Regards
>>>> > Freeman
>>>> > >
>>>> > > On my todo list is:
>>>> > > - Merge https://github.com/apache/cxf/pull/615 <
>>>> > https://github.com/apache/cxf/pull/615>
>>>> > > - Update XML Schema (currently under vote)
>>>> > > - Merge a fix for the regression introduced by CXF-8088.
>>>> > >
>>>> > > Colm.
>>>> > >
>>>> >
>>>> >
>>>>
>>>
Re: Votes by end of week?
Posted by Andrey Redko <dr...@gmail.com>.
Hey Andy,
I would finish up with SSE today, I was reading through the callback
discussion threads you mentioned, we may need to change a few things before
merge. The TCK formparam fixes look good to me, but I haven't dug into the
cause to be honest, Colm if you could take a look would be awesome, +1 from
me to merge. For CDI one I would appreciate to have some time to finish the
review, thanks!
Best Regards,
Andriy Redko
On Wed, Jan 8, 2020, 12:35 PM Colm O hEigeartaigh <co...@apache.org>
wrote:
> No objections from me for including them, if Andriy is happy with them.
> Otherwise we can leave them for 3.3.6.
>
> Colm.
>
> On Wed, Jan 8, 2020 at 5:19 PM Andy McCright <j....@gmail.com>
> wrote:
>
>> Andriy, Colm,
>>
>> I've three pull requests in progress that we could pull in - I'd like to
>> get some more reviews on them, but otherwise I think they are ready to
>> merge. That said, I'm fine with waiting until the next release too. The
>> PRs in question are:
>> https://github.com/apache/cxf/pull/619 - Adding injection into MP Rest
>> Client's ClientHeadersFactory - this will be part of the next MP spec (not
>> yet released), thus no urgency, but still a nice feature.
>> https://github.com/apache/cxf/pull/621 - fixes some Jakarta EE JAX-RS
>> TCK failures in the SSE bucket.
>> https://github.com/apache/cxf/pull/620 - fixes some Jakarta EE JAX-RS
>> TCK failures related to FormParam processing.
>>
>> Do you want to include them in the 3.3.5?
>>
>> Thanks, Andy
>>
>> On Wed, Jan 8, 2020 at 9:49 AM Colm O hEigeartaigh <co...@apache.org>
>> wrote:
>>
>>> OK thanks Freeman. As of this point I'm all done with the release.
>>> @Andriy
>>> Redko <dr...@gmail.com> please reply when you're finished with any
>>> changes
>>> and we can start the votes.
>>>
>>> Colm.
>>>
>>> On Wed, Jan 8, 2020 at 3:00 PM ffang <fr...@gmail.com> wrote:
>>>
>>> >
>>> >
>>> > > On Jan 6, 2020, at 1:16 PM, Colm O hEigeartaigh <coheigea@apache.org
>>> >
>>> > wrote:
>>> > >
>>> > > Hi all,
>>> > >
>>> > > It would be good to get votes started on new 3.3 + 3.2 releases by
>>> the
>>> > end of this week, as we are already overdue. We already have 32 JIRAs
>>> fixed
>>> > for 3.3.5, so it's shaping up to be a pretty big release!
>>> > >
>>> > > There are 2 remaining JIRA issues targetted for 3.3.5, both assigned
>>> to
>>> > Freeman. @Freeman Fang <ma...@gmail.com> do you think
>>> you
>>> > have time to look at them? Otherwise they can be moved to 3.3.6.
>>> > Hi Colm,
>>> >
>>> > Both CXF-8173 and CXF-8183 are same issue, they are harmless in terms
>>> of
>>> > function at this stage and we can revisit in the future.
>>> > Btw, I added comment here to explain it a bit
>>> >
>>> >
>>> >
>>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
>>> > <
>>> >
>>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
>>> > >
>>> >
>>> > Best Regards
>>> > Freeman
>>> > >
>>> > > On my todo list is:
>>> > > - Merge https://github.com/apache/cxf/pull/615 <
>>> > https://github.com/apache/cxf/pull/615>
>>> > > - Update XML Schema (currently under vote)
>>> > > - Merge a fix for the regression introduced by CXF-8088.
>>> > >
>>> > > Colm.
>>> > >
>>> >
>>> >
>>>
>>
Re: Votes by end of week?
Posted by Colm O hEigeartaigh <co...@apache.org>.
No objections from me for including them, if Andriy is happy with them.
Otherwise we can leave them for 3.3.6.
Colm.
On Wed, Jan 8, 2020 at 5:19 PM Andy McCright <j....@gmail.com>
wrote:
> Andriy, Colm,
>
> I've three pull requests in progress that we could pull in - I'd like to
> get some more reviews on them, but otherwise I think they are ready to
> merge. That said, I'm fine with waiting until the next release too. The
> PRs in question are:
> https://github.com/apache/cxf/pull/619 - Adding injection into MP Rest
> Client's ClientHeadersFactory - this will be part of the next MP spec (not
> yet released), thus no urgency, but still a nice feature.
> https://github.com/apache/cxf/pull/621 - fixes some Jakarta EE JAX-RS TCK
> failures in the SSE bucket.
> https://github.com/apache/cxf/pull/620 - fixes some Jakarta EE JAX-RS TCK
> failures related to FormParam processing.
>
> Do you want to include them in the 3.3.5?
>
> Thanks, Andy
>
> On Wed, Jan 8, 2020 at 9:49 AM Colm O hEigeartaigh <co...@apache.org>
> wrote:
>
>> OK thanks Freeman. As of this point I'm all done with the release. @Andriy
>> Redko <dr...@gmail.com> please reply when you're finished with any
>> changes
>> and we can start the votes.
>>
>> Colm.
>>
>> On Wed, Jan 8, 2020 at 3:00 PM ffang <fr...@gmail.com> wrote:
>>
>> >
>> >
>> > > On Jan 6, 2020, at 1:16 PM, Colm O hEigeartaigh <co...@apache.org>
>> > wrote:
>> > >
>> > > Hi all,
>> > >
>> > > It would be good to get votes started on new 3.3 + 3.2 releases by the
>> > end of this week, as we are already overdue. We already have 32 JIRAs
>> fixed
>> > for 3.3.5, so it's shaping up to be a pretty big release!
>> > >
>> > > There are 2 remaining JIRA issues targetted for 3.3.5, both assigned
>> to
>> > Freeman. @Freeman Fang <ma...@gmail.com> do you think you
>> > have time to look at them? Otherwise they can be moved to 3.3.6.
>> > Hi Colm,
>> >
>> > Both CXF-8173 and CXF-8183 are same issue, they are harmless in terms of
>> > function at this stage and we can revisit in the future.
>> > Btw, I added comment here to explain it a bit
>> >
>> >
>> >
>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
>> > <
>> >
>> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
>> > >
>> >
>> > Best Regards
>> > Freeman
>> > >
>> > > On my todo list is:
>> > > - Merge https://github.com/apache/cxf/pull/615 <
>> > https://github.com/apache/cxf/pull/615>
>> > > - Update XML Schema (currently under vote)
>> > > - Merge a fix for the regression introduced by CXF-8088.
>> > >
>> > > Colm.
>> > >
>> >
>> >
>>
>
Re: Votes by end of week?
Posted by Andy McCright <j....@gmail.com>.
Andriy, Colm,
I've three pull requests in progress that we could pull in - I'd like to
get some more reviews on them, but otherwise I think they are ready to
merge. That said, I'm fine with waiting until the next release too. The
PRs in question are:
https://github.com/apache/cxf/pull/619 - Adding injection into MP Rest
Client's ClientHeadersFactory - this will be part of the next MP spec (not
yet released), thus no urgency, but still a nice feature.
https://github.com/apache/cxf/pull/621 - fixes some Jakarta EE JAX-RS TCK
failures in the SSE bucket.
https://github.com/apache/cxf/pull/620 - fixes some Jakarta EE JAX-RS TCK
failures related to FormParam processing.
Do you want to include them in the 3.3.5?
Thanks, Andy
On Wed, Jan 8, 2020 at 9:49 AM Colm O hEigeartaigh <co...@apache.org>
wrote:
> OK thanks Freeman. As of this point I'm all done with the release. @Andriy
> Redko <dr...@gmail.com> please reply when you're finished with any
> changes
> and we can start the votes.
>
> Colm.
>
> On Wed, Jan 8, 2020 at 3:00 PM ffang <fr...@gmail.com> wrote:
>
> >
> >
> > > On Jan 6, 2020, at 1:16 PM, Colm O hEigeartaigh <co...@apache.org>
> > wrote:
> > >
> > > Hi all,
> > >
> > > It would be good to get votes started on new 3.3 + 3.2 releases by the
> > end of this week, as we are already overdue. We already have 32 JIRAs
> fixed
> > for 3.3.5, so it's shaping up to be a pretty big release!
> > >
> > > There are 2 remaining JIRA issues targetted for 3.3.5, both assigned to
> > Freeman. @Freeman Fang <ma...@gmail.com> do you think you
> > have time to look at them? Otherwise they can be moved to 3.3.6.
> > Hi Colm,
> >
> > Both CXF-8173 and CXF-8183 are same issue, they are harmless in terms of
> > function at this stage and we can revisit in the future.
> > Btw, I added comment here to explain it a bit
> >
> >
> >
> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
> > <
> >
> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
> > >
> >
> > Best Regards
> > Freeman
> > >
> > > On my todo list is:
> > > - Merge https://github.com/apache/cxf/pull/615 <
> > https://github.com/apache/cxf/pull/615>
> > > - Update XML Schema (currently under vote)
> > > - Merge a fix for the regression introduced by CXF-8088.
> > >
> > > Colm.
> > >
> >
> >
>
Re: Votes by end of week?
Posted by Colm O hEigeartaigh <co...@apache.org>.
OK thanks Freeman. As of this point I'm all done with the release. @Andriy
Redko <dr...@gmail.com> please reply when you're finished with any changes
and we can start the votes.
Colm.
On Wed, Jan 8, 2020 at 3:00 PM ffang <fr...@gmail.com> wrote:
>
>
> > On Jan 6, 2020, at 1:16 PM, Colm O hEigeartaigh <co...@apache.org>
> wrote:
> >
> > Hi all,
> >
> > It would be good to get votes started on new 3.3 + 3.2 releases by the
> end of this week, as we are already overdue. We already have 32 JIRAs fixed
> for 3.3.5, so it's shaping up to be a pretty big release!
> >
> > There are 2 remaining JIRA issues targetted for 3.3.5, both assigned to
> Freeman. @Freeman Fang <ma...@gmail.com> do you think you
> have time to look at them? Otherwise they can be moved to 3.3.6.
> Hi Colm,
>
> Both CXF-8173 and CXF-8183 are same issue, they are harmless in terms of
> function at this stage and we can revisit in the future.
> Btw, I added comment here to explain it a bit
>
>
> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
> <
> https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739
> >
>
> Best Regards
> Freeman
> >
> > On my todo list is:
> > - Merge https://github.com/apache/cxf/pull/615 <
> https://github.com/apache/cxf/pull/615>
> > - Update XML Schema (currently under vote)
> > - Merge a fix for the regression introduced by CXF-8088.
> >
> > Colm.
> >
>
>
Re: Votes by end of week?
Posted by ffang <fr...@gmail.com>.
> On Jan 6, 2020, at 1:16 PM, Colm O hEigeartaigh <co...@apache.org> wrote:
>
> Hi all,
>
> It would be good to get votes started on new 3.3 + 3.2 releases by the end of this week, as we are already overdue. We already have 32 JIRAs fixed for 3.3.5, so it's shaping up to be a pretty big release!
>
> There are 2 remaining JIRA issues targetted for 3.3.5, both assigned to Freeman. @Freeman Fang <ma...@gmail.com> do you think you have time to look at them? Otherwise they can be moved to 3.3.6.
Hi Colm,
Both CXF-8173 and CXF-8183 are same issue, they are harmless in terms of function at this stage and we can revisit in the future.
Btw, I added comment here to explain it a bit
https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739 <https://issues.apache.org/jira/browse/CXF-8173?focusedCommentId=17010739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17010739>
Best Regards
Freeman
>
> On my todo list is:
> - Merge https://github.com/apache/cxf/pull/615 <https://github.com/apache/cxf/pull/615>
> - Update XML Schema (currently under vote)
> - Merge a fix for the regression introduced by CXF-8088.
>
> Colm.
>
Re: Votes by end of week?
Posted by Colm O hEigeartaigh <co...@apache.org>.
OK done (to 3.3.x only, let me know if you want it in 3.2.x as well).
Colm.
On Mon, Jan 6, 2020 at 8:17 PM Alexey Markevich <bu...@gmail.com> wrote:
> Hi Colm,
> Include https://github.com/apache/cxf/pull/585 please
>
>
> On 1/6/20, Colm O hEigeartaigh <co...@apache.org> wrote:
> > Hi all,
> >
> > It would be good to get votes started on new 3.3 + 3.2 releases by the
> end
> > of this week, as we are already overdue. We already have 32 JIRAs fixed
> for
> > 3.3.5, so it's shaping up to be a pretty big release!
> >
> > There are 2 remaining JIRA issues targetted for 3.3.5, both assigned to
> > Freeman. @Freeman Fang <fr...@gmail.com> do you think you have
> time
> > to look at them? Otherwise they can be moved to 3.3.6.
> >
> > On my todo list is:
> > - Merge https://github.com/apache/cxf/pull/615
> > - Update XML Schema (currently under vote)
> > - Merge a fix for the regression introduced by CXF-8088.
> >
> > Colm.
> >
>
Re: Votes by end of week?
Posted by Alexey Markevich <bu...@gmail.com>.
Hi Colm,
Include https://github.com/apache/cxf/pull/585 please
On 1/6/20, Colm O hEigeartaigh <co...@apache.org> wrote:
> Hi all,
>
> It would be good to get votes started on new 3.3 + 3.2 releases by the end
> of this week, as we are already overdue. We already have 32 JIRAs fixed for
> 3.3.5, so it's shaping up to be a pretty big release!
>
> There are 2 remaining JIRA issues targetted for 3.3.5, both assigned to
> Freeman. @Freeman Fang <fr...@gmail.com> do you think you have time
> to look at them? Otherwise they can be moved to 3.3.6.
>
> On my todo list is:
> - Merge https://github.com/apache/cxf/pull/615
> - Update XML Schema (currently under vote)
> - Merge a fix for the regression introduced by CXF-8088.
>
> Colm.
>