[jira] [Commented] (NET-422) FTP using HTTP proxy not working

["Magnus Johansson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NET-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114844#comment-13114844 ] 

Magnus Johansson commented on NET-422:
--------------------------------------

I ran into this problem in one of my projects and have attached a patch for it to this issue.

Fix summary:

* _openDataConnection_ now acutely try to establish the connection through the proxy. (The implementation now reuses the parse functions for the "pasv" response from FTPClient so they have been made protected)
* connect now calls super._connectAction_() to get the member variable initialization right
* Added the "Host" header to the proxy connect call, its required by some proxies
* Fixed the user/password if-statement and base64 encoding issues in tunnelHandshake, which was also noted by Tomas in the last comment

* (Also added some new switches to the examples.ftp.FTPClientExample so that it can be used to test the FTPHTTPClient impl as well)

I have tested the patch against BlueCoat and Squid proxy installations successfully

Hope the patch can be of some use

Regards,
    Magnus

> FTP using HTTP proxy not working
> --------------------------------
>
>                 Key: NET-422
>                 URL: https://issues.apache.org/jira/browse/NET-422
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.0.1
>         Environment: java version "1.6.0_26"
>  Java(TM) SE Runtime Environment (build 1.6.0_26-b03)
>  Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02, mixed mode)
> Linux cattie 2.6.38-10-generic #46-Ubuntu SMP Tue Jun 28 15:07:17 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux
>            Reporter: Tomas Mysik
>         Attachments: FtpHttpClient.patch
>
>
> I know that FTPHTTPClient is experimental, but - I have discovered 2 bugs in it:
> - response from proxy is taken only if username and password are set
> - username and response are not correctly provided to Base64.encode() method
> I will attach a patch with proposed fix, feel free to apply it if you think it's correct.
> One more note: I'm not expert in this area so sorry if this question is nonsense but - shouldn't it be possible to connect to the encrypted FTP over HTTP proxy as well? Or am I completely wrong and this can't be ever possible.
> Thanks.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira