You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/17 08:39:09 UTC

[GitHub] [dolphinscheduler] lyggyhmm opened a new pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

lyggyhmm opened a new pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708


   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   
   [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl
   
   ## Brief change log
   
   * replace com.mysql.jdbc.Driver everywhere with com.mysql.cj.jdbc.Driver
   * append useSSL=false after the static parameter APPEND_PARAMS
   * update related unit tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on a change in pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r751137668



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       Of course, configuring useSSL=false should be more secure, after all, we do not use SSL certification




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971404872


   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6708](https://codecov.io/gh/apache/dolphinscheduler/pull/6708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da5e403) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/94352a4f5f44a167f99c7e115cb1e69647724079?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94352a4) will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dolphinscheduler/pull/6708/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dolphinscheduler/pull/6708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #6708      +/-   ##
   ============================================
   + Coverage     33.07%   33.08%   +0.01%     
   - Complexity     1619     1620       +1     
   ============================================
     Files           433      433              
     Lines         14292    14292              
     Branches       1427     1427              
   ============================================
   + Hits           4727     4729       +2     
   + Misses         9116     9111       -5     
   - Partials        449      452       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/6708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/dolphinscheduler/spi/task/TaskConstants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc3BpL3Rhc2svVGFza0NvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...g/apache/dolphinscheduler/spi/utils/Constants.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc3BpL3V0aWxzL0NvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...api/datasource/mysql/MysqlDatasourceProcessor.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1kYXRhc291cmNlLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLWRhdGFzb3VyY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi9kYXRhc291cmNlL2FwaS9kYXRhc291cmNlL215c3FsL015c3FsRGF0YXNvdXJjZVByb2Nlc3Nvci5qYXZh) | `62.85% <100.00%> (ø)` | |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.52% <0.00%> (+1.40%)` | :arrow_up: |
   | [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/dolphinscheduler/pull/6708/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `40.00% <0.00%> (+2.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6708?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/6708?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94352a4...da5e403](https://codecov.io/gh/apache/dolphinscheduler/pull/6708?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-972405072


   Hi @lyggyhmm , thanks for your contribution and welcome to join community 🎉 . If you want contribute but could not find issue, maybe you could start in #5689 or just search our issue list https://github.com/apache/dolphinscheduler/issues. Looking forward to your next contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-972431622


   > @lyggyhmm Pr merged, thanks for your contribution, this is your first contribution, you can contact to @zhongjiajie or me by email, we will help you join developer discussion groups.
   
   Thank you for your affirmation! In my spare time, I will continue to pay attention to the dynamics of the DS community and continue to contribute my own strength! I have been in the DS seed incubator group before, and would like to ask if I can join the contributor group now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm removed a comment on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm removed a comment on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971220429


   > 等一下，我们为什么要`dolphinscheduler-dao/src/main/resources/datasource.properties`在这里添加文件？@lyggyhmm 是不是偶然添加的
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971220429


   > 等一下，我们为什么要`dolphinscheduler-dao/src/main/resources/datasource.properties`在这里添加文件？@lyggyhmm 是不是偶然添加的
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] removed a comment on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-962998370


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL)
   
   [![25.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png '25.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_coverage&view=list) [25.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-972379039


   @lyggyhmm Pr merged, thanks for your contribution, this is your first contribution, you can contact to @zhongjiajie or me by email, we will help you join developer discussion groups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971221865


   > Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your PR describe. I would not only connect issue to PR but also close issue automatically when PR is be closed.
   
   
   
   > Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your PR describe. I would not only connect issue to PR but also close issue automatically when PR is be closed.
   
   Thank you for your guidance. This is the first time I mention PR here. I may not do well in some places. I will continue to improve in the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm closed pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm closed pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r751062749



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       @lyggyhmm Everything looks good, one minor may need to change.
   Do we require adding  `useSSL=false` in `datasource.properties` ? I worried that some new user may meet problem here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-972432161


   > Hi @lyggyhmm , thanks for your contribution and welcome to join community 🎉 . If you want contribute but could not find issue, maybe you could start in #5689 or just search our issue list https://github.com/apache/dolphinscheduler/issues. Looking forward to your next contribution
   
   Thank you for your affirmation! It’s an honor to join the community, and I still need your advice in the future


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on a change in pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r751136428



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       @ruanwenjun hi,the MySQL 8.X version does not seem to throw any warnings on the useSSL configuration, which has been tested on my own server. Of course, my knowledge is limited, I want to know what insights you have




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on a change in pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r751141862



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       I have removed the useSSL=false configuration last week




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun merged pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
ruanwenjun merged pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-962998370


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL)
   
   [![25.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png '25.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_coverage&view=list) [25.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-972463001


   > Thank you for your affirmation! In my spare time, I will continue to pay attention to the dynamics of the DS community and continue to contribute my own strength! I have been in the DS seed incubator group before, and would like to ask if I can join the contributor group now
   
   @lyggyhmm Will connect you in seed incubator wechat group


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on a change in pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r744447665



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       Okay, let me try without adding it for now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on a change in pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r746361432



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       already solved




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie edited a comment on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971163790


   Wait a minute, why should we add file `dolphinscheduler-dao/src/main/resources/datasource.properties` here? @lyggyhmm 
   does it add by accident


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971163790


   Wait a minute, why we should add file `dolphinscheduler-dao/src/main/resources/datasource.properties` here? @lyggyhmm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971220708


   > Wait a minute, why should we add file `dolphinscheduler-dao/src/main/resources/datasource.properties` here? @lyggyhmm does it add by accident
   
   It seems that there was this file before. It is not enough to see that it was deleted on the 14th in the submission record. It may be that I had a little accident during fetch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971254949


   > > Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your PR describe. I would not only connect issue to PR but also close issue automatically when PR is be closed.
   > 
   > > Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your PR describe. I would not only connect issue to PR but also close issue automatically when PR is be closed.
   > 
   > Thank you for your guidance. This is the first time I mention PR here. I may not do well in some places. I will continue to improve in the future.
   
   Hi @lyggyhmm you could reopen this PR, and just edited PR describe, we would help you finish your work.
   BTW, code look good to me, you just need to remove unnecessary `dolphinscheduler-dao/src/main/resources/datasource.properties`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on a change in pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r751135991



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       The MySQL 8.X version does not seem to throw any warnings on the useSSL configuration, which has been tested on my own server. Of course, my knowledge is limited, I want to know what insights you have




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r751146867



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       That's ok.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r744075193



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       I am not sure set `useSSL=false` here is reasonable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#discussion_r746283357



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
##########
@@ -51,7 +51,7 @@
 
     private static final String ALLOW_URL_IN_LOCAL_IN_FILE_NAME = "allowUrlInLocalInfile";
 
-    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false";
+    private static final String APPEND_PARAMS = "allowLoadLocalInfile=false&autoDeserialize=false&allowLocalInfile=false&allowUrlInLocalInfile=false&useSSL=false";

Review comment:
       Please rebase the upstream code and resolve the conflicts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #6708: [DS-6505][Dao] upgrade the MySQL driver package and add the useSSL parameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971162844


   Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your PR describe. I would not only connect issue to PR but also close issue automatically when PR is be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] lyggyhmm commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
lyggyhmm commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971365749


   > > > Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your PR describe. I would not only connect issue to PR but also close issue automatically when PR is be closed.
   > > 
   > > 
   > > > Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword `fix: #issue_id` or `close: #issue_id` or `closes: #issue_id` in your PR describe. I would not only connect issue to PR but also close issue automatically when PR is be closed.
   > > 
   > > 
   > > Thank you for your guidance. This is the first time I mention PR here. I may not do well in some places. I will continue to improve in the future.
   > 
   > Hi @lyggyhmm you could reopen this PR, and just edited PR describe, we would help you finish your work. BTW, code look good to me, you just need to remove unnecessary `dolphinscheduler-dao/src/main/resources/datasource.properties`
   
   Now, I modified the PR according to your prompts and re-edited the PR description. Please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #6708: [FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #6708:
URL: https://github.com/apache/dolphinscheduler/pull/6708#issuecomment-971408596


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=6708&resolved=false&types=CODE_SMELL)
   
   [![60.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '60.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_coverage&view=list) [60.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=6708&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org