You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/02 07:31:54 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #224: fix: broken e2e test case
tokers opened a new pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224
The image apache/apisix:dev was updated these two days, the status code when upstream is not available was changed from 502 to 503, so the e2e case should also be adjusted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #224: fix: broken e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224#issuecomment-771438286
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=h1) Report
> Merging [#224](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=desc) (fde365c) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ae48fa3510a0beb8e9880c41204a2d778ffbdffe?el=desc) (ae48fa3) will **increase** coverage by `54.43%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #224 +/- ##
============================================
+ Coverage 45.56% 100.00% +54.43%
============================================
Files 33 1 -32
Lines 2028 1 -2027
============================================
- Hits 924 1 -923
+ Misses 968 0 -968
+ Partials 136 0 -136
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | |
| [pkg/types/timeduration.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL3RpbWVkdXJhdGlvbi5nbw==) | | |
| [pkg/ingress/apisix/annotation.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L2Fubm90YXRpb24uZ28=) | | |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | | |
| [pkg/version/version.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3ZlcnNpb24vdmVyc2lvbi5nbw==) | | |
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | | |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | | |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | | |
| [pkg/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zZXJ2aWNlLmdv) | | |
| [pkg/seven/conf/conf.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2NvbmYvY29uZi5nbw==) | | |
| ... and [24 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=footer). Last update [ae48fa3...fde365c](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #224: fix: broken e2e test case
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224#issuecomment-771438286
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=h1) Report
> Merging [#224](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=desc) (fde365c) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ae48fa3510a0beb8e9880c41204a2d778ffbdffe?el=desc) (ae48fa3) will **increase** coverage by `54.43%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #224 +/- ##
============================================
+ Coverage 45.56% 100.00% +54.43%
============================================
Files 33 1 -32
Lines 2028 1 -2027
============================================
- Hits 924 1 -923
+ Misses 968 0 -968
+ Partials 136 0 -136
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | |
| [pkg/types/timeduration.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL3RpbWVkdXJhdGlvbi5nbw==) | | |
| [pkg/ingress/apisix/annotation.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L2Fubm90YXRpb24uZ28=) | | |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | | |
| [pkg/version/version.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3ZlcnNpb24vdmVyc2lvbi5nbw==) | | |
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | | |
| [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | | |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | | |
| [pkg/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9zZXJ2aWNlLmdv) | | |
| [pkg/seven/conf/conf.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2NvbmYvY29uZi5nbw==) | | |
| ... and [24 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=footer). Last update [ae48fa3...fde365c](https://codecov.io/gh/apache/apisix-ingress-controller/pull/224?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #224: fix: broken e2e test case
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224#issuecomment-771431431
@gxthrj @membphis Please take a look at this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #224: fix: broken e2e test case
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #224: fix: broken e2e test case
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #224: fix: broken e2e test case
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #224:
URL: https://github.com/apache/apisix-ingress-controller/pull/224#issuecomment-771431431
@gxthrj @membphis Please take a look at this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org