You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by ykrips <gi...@git.apache.org> on 2014/11/12 06:31:46 UTC
[GitHub] tajo pull request: TAJO-1165: Needs to show error messages on quer...
GitHub user ykrips opened a pull request:
https://github.com/apache/tajo/pull/238
TAJO-1165: Needs to show error messages on query_executor.jsp
Added error handling codes on QueryExecutorServlet.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykrips/tajo TAJO-1165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit a9f21c4c0a874ad336a325a5794515196ef1711e
Author: Jihun Kang <yk...@gmail.com>
Date: 2014-11-12T05:30:43Z
TAJO-1165: Needs to show error messages on query_executor.jsp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1165: Needs to show error messages on quer...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/238#issuecomment-64318014
Hi @ykrips
Could you close this issue? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1165: Needs to show error messages on quer...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/238#issuecomment-63597543
I have one more suggestion. If you possible, could you replace current javascript alert message to "Query execution failed" at query_executor.jsp?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1165: Needs to show error messages on quer...
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:
https://github.com/apache/tajo/pull/238#issuecomment-63766883
That's great. Your suggestion would give better user experience on web gui. I will commit it in a short time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1165: Needs to show error messages on quer...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/238#discussion_r20559308
--- Diff: tajo-core/src/main/java/org/apache/tajo/webapp/QueryExecutorServlet.java ---
@@ -300,6 +300,19 @@ public void run() {
progress.set(100);
}
+ } else if (response.getResultCode() == ClientProtos.ResultCode.ERROR) {
+ if (response.hasErrorMessage()) {
+ StringBuffer errorMessage = new StringBuffer(response.getErrorMessage());
+ String modifiedMessage;
+
+ if (errorMessage.length() > 200) {
+ modifiedMessage = errorMessage.substring(0, 200);
+ } else {
+ modifiedMessage = errorMessage.toString();
+ }
+
+ error = new Exception(modifiedMessage);
--- End diff --
How about replace all "\n" of modifiedMessage to "<br/>"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1165: Needs to show error messages on quer...
Posted by ykrips <gi...@git.apache.org>.
Github user ykrips closed the pull request at:
https://github.com/apache/tajo/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1165: Needs to show error messages on quer...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/238#issuecomment-64300349
+1
Thanks @ykrips .
I've just found that it worked on my testing cluster.
I'm going to push it to the master branch for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---