You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Dmitry Irlyanov (JIRA)" <ji...@apache.org> on 2007/08/21 14:23:30 UTC

[jira] Created: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

[classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
--------------------------------------------------------------------------------------------------------

                 Key: HARMONY-4658
                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Dmitry Irlyanov


The order of itemStateChanged events is fifferent for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue

import java.awt.event.ItemEvent;
import java.awt.event.ItemListener;

import javax.swing.AbstractButton;
import javax.swing.ButtonGroup;
import javax.swing.JRadioButton;

public class Test {

    public static void main(String[] args) {

        ButtonGroup group = new ButtonGroup();

        JRadioButton b1 = new JRadioButton("First");
        JRadioButton b2 = new JRadioButton("Second");
        group.add(b1);
        group.add(b2);
        b1.setSelected(true);

        ItemListener buttonListener = new ItemListener() {

            public void itemStateChanged(ItemEvent e) {

                AbstractButton rb = (AbstractButton) e.getSource();
                System.err.println(rb.getText() + " state changed");

            }

        };

        b1.addItemListener(buttonListener);
        b2.addItemListener(buttonListener);

        b2.setSelected(true);
        b1.setSelected(true);
        b2.setSelected(true);
        b1.setSelected(true);
    }

}


Output:
RI:
First state changed
Second state changed
Second state changed
First state changed
First state changed
Second state changed
Second state changed
First state changed

Harmony: 
Second state changed
First state changed
First state changed
Second state changed
Second state changed
First state changed
First state changed
Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524544 ] 

Dmitry Irlyanov commented on HARMONY-4658:
------------------------------------------

Alexei,
It's my fault. Try this one

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-DefaultButtonModel-JToggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov closed HARMONY-4658.
------------------------------------


Alexei,
Thank you. All the changes are correct



> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-DefaultButtonModel-JToggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov resolved HARMONY-4658.
--------------------------------------

    Resolution: Fixed

This one is much better, thanks Dmitry. Applied at the revision 572950. Please verify.

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-DefaultButtonModel-JToggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov updated HARMONY-4658:
-------------------------------------

    Description: 
The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue

import java.awt.event.ItemEvent;
import java.awt.event.ItemListener;

import javax.swing.AbstractButton;
import javax.swing.ButtonGroup;
import javax.swing.JRadioButton;

public class Test {

    public static void main(String[] args) {

        ButtonGroup group = new ButtonGroup();

        JRadioButton b1 = new JRadioButton("First");
        JRadioButton b2 = new JRadioButton("Second");
        group.add(b1);
        group.add(b2);
        b1.setSelected(true);

        ItemListener buttonListener = new ItemListener() {

            public void itemStateChanged(ItemEvent e) {

                AbstractButton rb = (AbstractButton) e.getSource();
                System.err.println(rb.getText() + " state changed");

            }

        };

        b1.addItemListener(buttonListener);
        b2.addItemListener(buttonListener);

        b2.setSelected(true);
        b1.setSelected(true);
        b2.setSelected(true);
        b1.setSelected(true);
    }

}


Output:
RI:
First state changed
Second state changed
Second state changed
First state changed
First state changed
Second state changed
Second state changed
First state changed

Harmony: 
Second state changed
First state changed
First state changed
Second state changed
Second state changed
First state changed
First state changed
Second state changed

  was:
The order of itemStateChanged events is fifferent for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue

import java.awt.event.ItemEvent;
import java.awt.event.ItemListener;

import javax.swing.AbstractButton;
import javax.swing.ButtonGroup;
import javax.swing.JRadioButton;

public class Test {

    public static void main(String[] args) {

        ButtonGroup group = new ButtonGroup();

        JRadioButton b1 = new JRadioButton("First");
        JRadioButton b2 = new JRadioButton("Second");
        group.add(b1);
        group.add(b2);
        b1.setSelected(true);

        ItemListener buttonListener = new ItemListener() {

            public void itemStateChanged(ItemEvent e) {

                AbstractButton rb = (AbstractButton) e.getSource();
                System.err.println(rb.getText() + " state changed");

            }

        };

        b1.addItemListener(buttonListener);
        b2.addItemListener(buttonListener);

        b2.setSelected(true);
        b1.setSelected(true);
        b2.setSelected(true);
        b1.setSelected(true);
    }

}


Output:
RI:
First state changed
Second state changed
Second state changed
First state changed
First state changed
Second state changed
Second state changed
First state changed

Harmony: 
Second state changed
First state changed
First state changed
Second state changed
Second state changed
First state changed
First state changed
Second state changed


> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov updated HARMONY-4658:
-------------------------------------

    Attachment:     (was: H4658-TogggleButton.patch)

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-DefaultButtonModel-JToggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov updated HARMONY-4658:
-------------------------------------

    Attachment: H4658-DefaultButtonModel-JToggleButton.patch

Alexey,
It's my fault. Try this one

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-DefaultButtonModel-JToggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov updated HARMONY-4658:
-------------------------------------

    Patch Info: [Patch Available]

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>         Attachments: H4658-TogggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov reassigned HARMONY-4658:
----------------------------------------

    Assignee: Alexei Zakharov

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-TogggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov updated HARMONY-4658:
-------------------------------------

    Attachment: H4658-TogggleButton.patch

Proposed fix

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>         Attachments: H4658-TogggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Irlyanov updated HARMONY-4658:
-------------------------------------

    Comment: was deleted

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-DefaultButtonModel-JToggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-4658) [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Zakharov updated HARMONY-4658:
-------------------------------------


Dmitry, your patch introduces about 70 failures of various SWING tests - a kind of some deadlock issue. Could you please try to run all SWING tests and see the reason of these failures?

> [classlib][swing][compartibility] The order of ItemStateChanged events in buttonGroup is differs from RI
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-4658
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4658
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Dmitry Irlyanov
>            Assignee: Alexei Zakharov
>         Attachments: H4658-TogggleButton.patch
>
>
> The order of itemStateChanged events is different for RI and for our implementation. It isn't a bug because the behavior is unspecified, but some applications may rely on this issue
> import java.awt.event.ItemEvent;
> import java.awt.event.ItemListener;
> import javax.swing.AbstractButton;
> import javax.swing.ButtonGroup;
> import javax.swing.JRadioButton;
> public class Test {
>     public static void main(String[] args) {
>         ButtonGroup group = new ButtonGroup();
>         JRadioButton b1 = new JRadioButton("First");
>         JRadioButton b2 = new JRadioButton("Second");
>         group.add(b1);
>         group.add(b2);
>         b1.setSelected(true);
>         ItemListener buttonListener = new ItemListener() {
>             public void itemStateChanged(ItemEvent e) {
>                 AbstractButton rb = (AbstractButton) e.getSource();
>                 System.err.println(rb.getText() + " state changed");
>             }
>         };
>         b1.addItemListener(buttonListener);
>         b2.addItemListener(buttonListener);
>         b2.setSelected(true);
>         b1.setSelected(true);
>         b2.setSelected(true);
>         b1.setSelected(true);
>     }
> }
> Output:
> RI:
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> Harmony: 
> Second state changed
> First state changed
> First state changed
> Second state changed
> Second state changed
> First state changed
> First state changed
> Second state changed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.