You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/01/10 21:16:14 UTC
[kudu-CR] fs: update default data dir group size
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8995
Change subject: fs: update default data dir group size
......................................................................
fs: update default data dir group size
This patch makes fs_target_data_dirs_per_tablet non-experimental and
sets the new default to 3. Upon experimenting with the flag via YCSB
workloads, only read workload tail latency seemed to be affected at very
small group sizes (e.g. 1). 3 seems like a reasonable choice, and we can
always update it in the future.
Note that existing data will not be updated with the new flag. Only new
tablets will honor the sizing.
Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
---
M src/kudu/fs/data_dirs.cc
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/8995/1
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] fs: update default data dir group size
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 24 Jan 2018 20:48:56 +0000
Gerrit-HasComments: No
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8995
to look at the new patch set (#5).
Change subject: fs: update default data dir group size
......................................................................
fs: update default data dir group size
This patch makes fs_target_data_dirs_per_tablet non-experimental and
sets the new default to 3. Upon experimenting with the flag via YCSB
workloads, only read workload tail latency seemed to be affected at very
small group sizes (e.g. 1). 3 seems like a reasonable choice, and we can
always update it in the future.
Note that existing data will not be updated with the new flag. Only new
tablets will honor the sizing.
Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
---
M src/kudu/fs/data_dirs.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/8995/5
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8995/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8995/3//COMMIT_MSG@10
PS3, Line 10: sets the new default to 3. Upon experimenting with the flag via YCSB
> I think we should also try an analytic workload like tpch_real_world to loa
Ack
http://gerrit.cloudera.org:8080/#/c/8995/3/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/8995/3/src/kudu/fs/data_dirs.cc@69
PS3, Line 69: "data dirs. Using fewer data dirs per tablet means a single "
> we should also document the effect this setting has on fault tolerance
Done
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 13 Jan 2018 17:43:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 2:
Interesting that this change is causing build failures of the randomized disk failure test. I think the lower group size is yielding fewer fsyncs for the tablet, since it's just not tripping the fault injection.
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 10 Jan 2018 23:11:56 +0000
Gerrit-HasComments: No
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8995/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8995/3//COMMIT_MSG@10
PS3, Line 10: sets the new default to 3. Upon experimenting with the flag via YCSB
> Ack
Done
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 24 Jan 2018 01:50:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8995
to look at the new patch set (#6).
Change subject: fs: update default data dir group size
......................................................................
fs: update default data dir group size
This patch makes fs_target_data_dirs_per_tablet non-experimental and
sets the new default to 3. Upon experimenting with the flag via YCSB
workloads, only read workload tail latency seemed to be affected at very
small group sizes (e.g. 1). 3 seems like a reasonable choice, and we can
always update it in the future.
Additionally, this change was tested on an 8-node cluster with an
analytical workload (TPC-H, scale factor: 300), each node with 7
data dirs and a separate WAL dir. I updated the disk group size to 3
and ran a TPC-H workload, results below averaged across 10 runs.
Size | q1 q2 q3 q4 q5 q6 q7 q8 q9 q10 q12 q13 q14 q15 q16 q17 q18 q19 q20 q21
All | 13.931 10.628 30.917 47.363 37.468 1.914 54.252 23.196 52.618 19.074 19.171 34.751 4.077 2.738 14.617 64.92 95.475 22.659 25.13 155.384
Three | 14.343 11.174 30.932 48.172 38.072 1.906 54.489 22.494 53.88 18.478 18.408 33.6 3.991 2.933 15.567 79.578 100.285 25.182 26.979 153.592
Slowdown | 0.412 0.546 0.015 0.809 0.604 -0.008 0.237 -0.702 1.262 -0.596 -0.763 -1.151 -0.086 0.195 0.95 14.658 4.81 2.523 1.849 -1.792
Note that existing data will not be updated with the new flag. Only new
tablets will honor the sizing.
Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
---
M src/kudu/fs/data_dirs.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/8995/6
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 3:
> Patch Set 2:
>
> Interesting that this change is causing build failures of the randomized disk failure test. I think the lower group size is yielding fewer fsyncs for the tablet, since it's just not tripping the fault injection.
Much simpler, the smaller disk group meant that failing the first non-metadata data directory didn't always work.
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 11 Jan 2018 02:02:04 +0000
Gerrit-HasComments: No
[kudu-CR] fs: update default data dir group size
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8995/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8995/3//COMMIT_MSG@10
PS3, Line 10: sets the new default to 3. Upon experimenting with the flag via YCSB
I think we should also try an analytic workload like tpch_real_world to load lineitem at a scale factor larger than memory (eg 1TB per node) and then scan it with Impala to make sure that it's not significantly slower.
http://gerrit.cloudera.org:8080/#/c/8995/3/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/8995/3/src/kudu/fs/data_dirs.cc@69
PS3, Line 69: "data directories.");
we should also document the effect this setting has on fault tolerance
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 11 Jan 2018 02:17:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: update default data dir group size
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 14 Jan 2018 06:16:11 +0000
Gerrit-HasComments: No
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8995/2/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/8995/2/src/kudu/fs/data_dirs.cc@73
PS2, Line 73: TAG_FLAG(fs_target_data_dirs_per_tablet, evolving);
> Not stable?
I'm looking at flag_tags.h and I think this could fall under "not yet locked down", particularly since we're still adjusting defaults. Once we get some more mileage, I'll be happy to change it.
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 10 Jan 2018 22:54:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8995
to look at the new patch set (#3).
Change subject: fs: update default data dir group size
......................................................................
fs: update default data dir group size
This patch makes fs_target_data_dirs_per_tablet non-experimental and
sets the new default to 3. Upon experimenting with the flag via YCSB
workloads, only read workload tail latency seemed to be affected at very
small group sizes (e.g. 1). 3 seems like a reasonable choice, and we can
always update it in the future.
This patch updates TabletServerDiskFailureTest::TestRandomOpSequence to
fail all data directories but the metadata directory, rather than just
the first non-metadata data dir. The previous failure injection
configuration wouldn't always select a data directory with blocks in it.
Note that existing data will not be updated with the new flag. Only new
tablets will honor the sizing.
Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
---
M src/kudu/fs/data_dirs.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 12 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/8995/3
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: update default data dir group size
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
fs: update default data dir group size
This patch makes fs_target_data_dirs_per_tablet non-experimental and
sets the new default to 3. Upon experimenting with the flag via YCSB
workloads, only read workload tail latency seemed to be affected at very
small group sizes (e.g. 1). 3 seems like a reasonable choice, and we can
always update it in the future.
Additionally, this change was tested on an 8-node cluster with an
analytical workload (TPC-H, scale factor: 300), each node with 7
data dirs and a separate WAL dir. I updated the disk group size to 3
and ran a TPC-H workload, results below averaged across 10 runs.
Size | q1 q2 q3 q4 q5 q6 q7 q8 q9 q10 q12 q13 q14 q15 q16 q17 q18 q19 q20 q21
All | 13.931 10.628 30.917 47.363 37.468 1.914 54.252 23.196 52.618 19.074 19.171 34.751 4.077 2.738 14.617 64.92 95.475 22.659 25.13 155.384
Three | 14.343 11.174 30.932 48.172 38.072 1.906 54.489 22.494 53.88 18.478 18.408 33.6 3.991 2.933 15.567 79.578 100.285 25.182 26.979 153.592
Slowdown | 0.412 0.546 0.015 0.809 0.604 -0.008 0.237 -0.702 1.262 -0.596 -0.763 -1.151 -0.086 0.195 0.95 14.658 4.81 2.523 1.849 -1.792
Note that existing data will not be updated with the new flag. Only new
tablets will honor the sizing.
Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Reviewed-on: http://gerrit.cloudera.org:8080/8995
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/fs/data_dirs.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 13 insertions(+), 10 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: update default data dir group size
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 )
Change subject: fs: update default data dir group size
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Since this change has non-trivial impact it would be nice to get it reviewed by 1-2 more folks.
http://gerrit.cloudera.org:8080/#/c/8995/2/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/8995/2/src/kudu/fs/data_dirs.cc@73
PS2, Line 73: TAG_FLAG(fs_target_data_dirs_per_tablet, evolving);
Not stable?
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 10 Jan 2018 22:32:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] fs: update default data dir group size
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8995
to look at the new patch set (#4).
Change subject: fs: update default data dir group size
......................................................................
fs: update default data dir group size
This patch makes fs_target_data_dirs_per_tablet non-experimental and
sets the new default to 3. Upon experimenting with the flag via YCSB
workloads, only read workload tail latency seemed to be affected at very
small group sizes (e.g. 1). 3 seems like a reasonable choice, and we can
always update it in the future.
Note that existing data will not be updated with the new flag. Only new
tablets will honor the sizing.
Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
---
M src/kudu/fs/data_dirs.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/8995/4
--
To view, visit http://gerrit.cloudera.org:8080/8995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2dd0d3f8cf140f684318c0dffb45a1091302ecdc
Gerrit-Change-Number: 8995
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>