You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2018/08/14 19:00:21 UTC
[Bug 62625] New: Regression in VBAMacroReader in 4.0.0-SNAPSHOT,
unexpected reserved byte
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
Bug ID: 62625
Summary: Regression in VBAMacroReader in 4.0.0-SNAPSHOT,
unexpected reserved byte
Product: POI
Version: 4.0-dev
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: POI Overall
Assignee: dev@poi.apache.org
Reporter: tallison@mitre.org
Target Milestone: ---
Created attachment 36092
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36092&action=edit
triggering document
New exception in 4.0.0-SNAPSHOT.
Caused by: java.io.IOException: Expected 3eafter name before Unicode name, but
found: d
at
org.apache.poi.poifs.macros.VBAMacroReader.readStringPair(VBAMacroReader.java:555)
at
org.apache.poi.poifs.macros.VBAMacroReader.processDirStream(VBAMacroReader.java:488)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved
byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
--- Comment #4 from PJ Fanning <fa...@yahoo.com> ---
The recent code changes seem to have introduced a number of new warnings in
https://lgtm.com/projects/g/apache/poi/alerts/?mode=list and in FindBugs output
(see the spike in https://builds.apache.org/view/P/view/POI/job/POI-DSL-1.8/)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved
byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
Tim Allison <ta...@mitre.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #5 from Tim Allison <ta...@mitre.org> ---
Doh. Fixing now. Thank you.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved
byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
--- Comment #3 from Tim Allison <ta...@mitre.org> ---
To clarify, this wasn't a regression. This was a bug that became apparent with
better exception handling.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved
byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
--- Comment #7 from Tim Allison <ta...@mitre.org> ---
And fix made to ensure closing of streams from lgtm. Thank you, again, PJ.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved
byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
Tim Allison <ta...@mitre.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Regression in |VBAMacroReader in
|VBAMacroReader in |4.0.0-SNAPSHOT, unexpected
|4.0.0-SNAPSHOT, unexpected |reserved byte
|reserved byte |
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] Regression in VBAMacroReader in 4.0.0-SNAPSHOT,
unexpected reserved byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
Tim Allison <ta...@mitre.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Tim Allison <ta...@mitre.org> ---
r1845238
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] Regression in VBAMacroReader in 4.0.0-SNAPSHOT,
unexpected reserved byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
Tim Allison <ta...@mitre.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Tim Allison <ta...@mitre.org> ---
See decalage's note:
https://github.com/decalage2/oletools/blob/master/oletools/olevba.py#L1516
# According to [MS-OVBA] 2.3.4.2.2.2 REFERENCENAME Record:
# "Reserved (2 bytes): MUST be 0x003E. MUST be ignored."
# So let's ignore it, otherwise it crashes on some files (issue #132)
# PR #135 by @c1fe:
# contrary to the specification I think that the unicode name
# is optional. if reference_reserved is not 0x003E I think it
# is actually the start of another REFERENCE record
# at least when projectsyskind_syskind == 0x02 (Macintosh)
Sometimes REFERENCENAME only has an ascii part, contrary to the spec.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62625] VBAMacroReader in 4.0.0-SNAPSHOT, unexpected reserved
byte
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62625
Tim Allison <ta...@mitre.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Tim Allison <ta...@mitre.org> ---
One dodgy loop fixed. Added other sanity checks. Thank you, PJ!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org