You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/03/11 11:48:14 UTC
[GitHub] [groovy] broecirr opened a new pull request #1516: GROOVY-9397: Make respondsTo thread safe
broecirr opened a new pull request #1516:
URL: https://github.com/apache/groovy/pull/1516
By changing the initialized state of the Closure's Metaclass without any
locking, if the Closure is visible to another thread, then any call to
invokeMethod can see an uninitialized closure, causing an exception.
This fix removes the need to change the initialized state of the
closure in loadMetaInfo().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1516: GROOVY-9397: Make respondsTo thread safe
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1516:
URL: https://github.com/apache/groovy/pull/1516#issuecomment-797782067
LGTM.
Could you add the test you mentioned?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] broecirr commented on pull request #1516: GROOVY-9397: Make respondsTo thread safe
Posted by GitBox <gi...@apache.org>.
broecirr commented on pull request #1516:
URL: https://github.com/apache/groovy/pull/1516#issuecomment-797334475
I don't see any Exceptions when running the example in the linked JIRA ticket with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 merged pull request #1516: GROOVY-9397: Make respondsTo thread safe
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1516:
URL: https://github.com/apache/groovy/pull/1516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1516: GROOVY-9397: Make respondsTo thread safe
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1516:
URL: https://github.com/apache/groovy/pull/1516#issuecomment-800267229
Merged. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org