[GitHub] [iceberg] stevenzwu commented on pull request #4529: Add a new TableScan#appendInRange method that accepts nullable fromSn…

[GitBox <gi...@apache.org>]

stevenzwu commented on PR #4529:
URL: https://github.com/apache/iceberg/pull/4529#issuecomment-1095844443

   @yittg this proposal is after the discussion with Ryan. The original plan was to provide an overloaded `appendsBetween` with `long` and `Long`. But during implementation, I found that overload caused compiling error as I mentioned in one of the comments. So I have to rename the new method to `appendsInRange`, which is not as good a name as `appendsBetween`. This PR is actually relatively small change even though it touched many files.
   
   Regarding special value, I am not sure if there is a special invalid snapshot id that Iceberg defines in the table format spec. The only special value is `null`. E.g., the earliest snapshot has `parent-snapshot-id` as null.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org