You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by marevol <gi...@git.apache.org> on 2017/04/26 23:25:53 UTC

[GitHub] incubator-predictionio pull request #374: ES storage improvement/refactoring

GitHub user marevol opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/374

    ES storage improvement/refactoring

    - Use the same ID generation for ES in event data
    - Reuse RestClient instance in ESLEvents
    - Replace 0 with false in mapping
    - Set Content-Type as application/json

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marevol/incubator-predictionio es_id_generate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #374
    
----
commit 125b624f9d2255fa6bccaec3e318df066698939d
Author: Shinsuke Sugaya <sh...@yahoo.co.jp>
Date:   2017-04-26T22:13:41Z

    replace id generation for es in events, modify mapping, and add content-type

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #374: ES storage improvement/refactoring

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio/pull/374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #374: ES storage improvement/refactoring

Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/374
  
    LGTM. I'd like to suggest us to get into the habit of filing JIRA tickets for all changes. It will make the release notes writer easier to figure out what's been changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---