You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/28 10:50:13 UTC

[GitHub] [flink] zhuzhurk commented on a change in pull request #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build

zhuzhurk commented on a change in pull request #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build
URL: https://github.com/apache/flink/pull/9783#discussion_r329306187
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobExecutionITCase.java
 ##########
 @@ -37,6 +39,7 @@
 /**
  * Integration tests for job scheduling.
  */
+@Category(AlsoRunWithSchedulerNG.class)
 public class JobExecutionITCase extends TestLogger {
 
 Review comment:
   This hotfix enabled NG scheduler testing for JobExecutionITCase which can pass at the moment.
   It helps to verify the changes of FLINK-14040.
   
   In this way we can have FLINK-14040 merged first. 
   FLINK-14040 would be helpful when we are to annotate (and maybe need to fix) more tests. We can tell if the change works by checking both the PR test result(so that it works for legacy) and the cron job result(so that it works for NG).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services