You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2017/08/25 11:21:49 UTC

[24/29] james-project git commit: JAMES-2124 Solve more Eclipse warnings

JAMES-2124 Solve more Eclipse warnings


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/4ba81026
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/4ba81026
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/4ba81026

Branch: refs/heads/master
Commit: 4ba81026e13f38f527d19494e7fb45457cf216a4
Parents: bca6e8d
Author: benwa <bt...@linagora.com>
Authored: Thu Aug 24 16:31:56 2017 +0700
Committer: benwa <bt...@linagora.com>
Committed: Fri Aug 25 18:18:14 2017 +0700

----------------------------------------------------------------------
 .../mailbox/store/mail/model/impl/MessageParserTest.java     | 8 ++++++--
 .../src/main/java/org/apache/james/rrt/lib/MappingsImpl.java | 1 +
 2 files changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/4ba81026/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/impl/MessageParserTest.java
----------------------------------------------------------------------
diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/impl/MessageParserTest.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/impl/MessageParserTest.java
index 2e82305..ff2f0f3 100644
--- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/impl/MessageParserTest.java
+++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/impl/MessageParserTest.java
@@ -154,7 +154,9 @@ public class MessageParserTest {
 
         assertThat(attachments).hasSize(1)
             .extracting(MessageAttachment::getName)
-            .containsExactly(Optional.of("inventory.csv"));
+            .allMatch(Optional::isPresent)
+            .extracting(Optional::get)
+            .containsExactly("inventory.csv");
     }
 
     @Test
@@ -163,7 +165,9 @@ public class MessageParserTest {
 
         assertThat(attachments).hasSize(1)
             .extracting(MessageAttachment::getName)
-            .containsExactly(Optional.of("good.csv"));
+            .allMatch(Optional::isPresent)
+            .extracting(Optional::get)
+            .containsExactly("good.csv");
     }
 
     @Test

http://git-wip-us.apache.org/repos/asf/james-project/blob/4ba81026/server/data/data-library/src/main/java/org/apache/james/rrt/lib/MappingsImpl.java
----------------------------------------------------------------------
diff --git a/server/data/data-library/src/main/java/org/apache/james/rrt/lib/MappingsImpl.java b/server/data/data-library/src/main/java/org/apache/james/rrt/lib/MappingsImpl.java
index 2bcf21e..4a4cb9b 100644
--- a/server/data/data-library/src/main/java/org/apache/james/rrt/lib/MappingsImpl.java
+++ b/server/data/data-library/src/main/java/org/apache/james/rrt/lib/MappingsImpl.java
@@ -129,6 +129,7 @@ public class MappingsImpl implements Mappings, Serializable {
     }
 
     @Override
+    @SuppressWarnings("unlikely-arg-type")
     public boolean contains(String mapping) {
         return mappings.contains(mapping);
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org