You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Renato Marroquin <re...@gmail.com> on 2013/11/09 00:13:53 UTC
Review Request 15376: Create VertexInputFormat from Apache Gora
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15376/
-----------------------------------------------------------
Review request for giraph and Claudio Martella.
Repository: giraph-git
Description
-------
Create VertexInputFormat from Apache Gora
Diffs
-----
giraph-gora/conf/edge.avsc PRE-CREATION
giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION
giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION
giraph-gora/conf/gora.properties PRE-CREATION
giraph-gora/conf/vertex.json PRE-CREATION
giraph-gora/conf/zoo.cfg PRE-CREATION
giraph-gora/pom.xml PRE-CREATION
giraph-gora/src/main/assembly/compile.xml PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexInputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexInputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexInputFormat.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexInputFormat.java PRE-CREATION
pom.xml cc2c9a8
Diff: https://reviews.apache.org/r/15376/diff/
Testing
-------
Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
Thanks,
Renato Marroquin
Re: Review Request 15376: Create VertexInputFormat from Apache Gora
Posted by Claudio Martella <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15376/#review28617
-----------------------------------------------------------
giraph-gora/pom.xml
<https://reviews.apache.org/r/15376/#comment55509>
are all these spaces necessary?
giraph-gora/pom.xml
<https://reviews.apache.org/r/15376/#comment55514>
i thought we did not need this.
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexInputFormat.java
<https://reviews.apache.org/r/15376/#comment55510>
you may want to specify that this is an example?
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexInputFormat.java
<https://reviews.apache.org/r/15376/#comment55511>
not sure this should be an error(). i can imagine it must be common to load the whole key range?
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java
<https://reviews.apache.org/r/15376/#comment55512>
also here, you may want to specify this is an example.
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java
<https://reviews.apache.org/r/15376/#comment55513>
remove space before "="
- Claudio Martella
On Nov. 8, 2013, 11:13 p.m., Renato Marroquin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15376/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 11:13 p.m.)
>
>
> Review request for giraph and Claudio Martella.
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> Create VertexInputFormat from Apache Gora
>
>
> Diffs
> -----
>
> giraph-gora/conf/edge.avsc PRE-CREATION
> giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION
> giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION
> giraph-gora/conf/gora.properties PRE-CREATION
> giraph-gora/conf/vertex.json PRE-CREATION
> giraph-gora/conf/zoo.cfg PRE-CREATION
> giraph-gora/pom.xml PRE-CREATION
> giraph-gora/src/main/assembly/compile.xml PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexInputFormat.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexInputFormat.java PRE-CREATION
> pom.xml cc2c9a8
>
> Diff: https://reviews.apache.org/r/15376/diff/
>
>
> Testing
> -------
>
> Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
>
>
> Thanks,
>
> Renato Marroquin
>
>
Re: Review Request 15376: Create VertexInputFormat from Apache Gora
Posted by Renato Marroquin <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15376/
-----------------------------------------------------------
(Updated Nov. 18, 2013, 1:04 a.m.)
Review request for giraph and Claudio Martella.
Changes
-------
Addinge changes needed.
Repository: giraph-git
Description
-------
Create VertexInputFormat from Apache Gora
Diffs (updated)
-----
giraph-gora/conf/edge.avsc PRE-CREATION
giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION
giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION
giraph-gora/conf/gora.properties PRE-CREATION
giraph-gora/conf/vertex.json PRE-CREATION
giraph-gora/conf/zoo.cfg PRE-CREATION
giraph-gora/pom.xml PRE-CREATION
giraph-gora/src/main/assembly/compile.xml PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexInputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexInputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/DefaultKeyFactory.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION
giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexInputFormat.java PRE-CREATION
giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexInputFormat.java PRE-CREATION
pom.xml bce0641
Diff: https://reviews.apache.org/r/15376/diff/
Testing
-------
Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
Thanks,
Renato Marroquin
Re: Review Request 15376: Create VertexInputFormat from Apache Gora
Posted by Claudio Martella <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15376/#review28618
-----------------------------------------------------------
Overall, this looks really good. I'd suggest a couple of cosmetic fixes. Also, please specify that certain classes are meant as examples, because it could be misleading to a new comer (as they are not in a specific package neither). Besides, do we really need the additional dependency to gora-hbase?
- Claudio Martella
On Nov. 8, 2013, 11:13 p.m., Renato Marroquin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15376/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 11:13 p.m.)
>
>
> Review request for giraph and Claudio Martella.
>
>
> Repository: giraph-git
>
>
> Description
> -------
>
> Create VertexInputFormat from Apache Gora
>
>
> Diffs
> -----
>
> giraph-gora/conf/edge.avsc PRE-CREATION
> giraph-gora/conf/gora-cassandra-mapping.xml PRE-CREATION
> giraph-gora/conf/gora-hbase-mapping.xml PRE-CREATION
> giraph-gora/conf/gora.properties PRE-CREATION
> giraph-gora/conf/vertex.json PRE-CREATION
> giraph-gora/conf/zoo.cfg PRE-CREATION
> giraph-gora/pom.xml PRE-CREATION
> giraph-gora/src/main/assembly/compile.xml PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraGVertexVertexInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/GoraVertexInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/GiraphGoraConstants.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/constants/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/GVertex.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/generated/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/package-info.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/ExtraGoraInputFormat.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/GoraUtils.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/KeyFactory.java PRE-CREATION
> giraph-gora/src/main/java/org/apache/giraph/io/gora/utils/package-info.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/GoraTestVertexInputFormat.java PRE-CREATION
> giraph-gora/src/test/java/org/apache/giraph/io/gora/TestGoraVertexInputFormat.java PRE-CREATION
> pom.xml cc2c9a8
>
> Diff: https://reviews.apache.org/r/15376/diff/
>
>
> Testing
> -------
>
> Created vertices inside Gora's InMemory DataStore and then test the whole API without needing any other external dependencies.
>
>
> Thanks,
>
> Renato Marroquin
>
>