You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ljmotta (via GitHub)" <gi...@apache.org> on 2025/01/02 17:16:30 UTC
Re: [PR] kie-issues#2821: KIE Tools: TypeError when invoking Java method inside BKM [incubator-kie-tools]
ljmotta commented on code in PR #2831:
URL: https://github.com/apache/incubator-kie-tools/pull/2831#discussion_r1901091743
##########
packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx:
##########
@@ -346,7 +346,13 @@ export function JavaFunctionExpression({
expression: {
__$$element: "context",
...context,
- contextEntry: [clazz, method],
+ contextEntry: [
+ {
+ ...clazz,
+ expression: newExpression,
Review Comment:
As we don't re-use the variable, could you inline it here?
##########
packages/boxed-expression-component/src/expressions/FunctionExpression/JavaFunctionExpression.tsx:
##########
@@ -371,7 +377,13 @@ export function JavaFunctionExpression({
expression: {
__$$element: "context",
...context,
- contextEntry: [clazz, method],
+ contextEntry: [
+ clazz,
+ {
+ ...method,
+ expression: newExpression,
Review Comment:
Same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org