[GitHub] [flink] dianfu commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API
URL: https://github.com/apache/flink/pull/7196#discussion_r273045966
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/OperationTreeBuilder.scala
 ##########
 @@ -376,6 +377,33 @@ class OperationTreeBuilder(private val tableEnv: TableEnvironment) {
     Project(expandedFields.map(UnresolvedAlias), childNode).validate(tableEnv)
   }
 
+  def flatMap(tableFunction: Expression, child: TableOperation): TableOperation = {
 
 Review comment:
   Good advice for using dropNode to remove the columns from the original inputs. Regarding to the logic to solve duplicate field names, I think it is still needed as input field names may be duplicate with the result field names of table function. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services