You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Craig Peterein <cr...@peterein.org> on 2002/12/05 04:50:12 UTC
[PATCH] svn_client.i (was: svn commit: rev 4002 - trunk/subversion/include)
On Wed, Dec 04, 2002 at 09:00:27PM -0600, rooneg@tigris.org wrote:
> Author: rooneg
> Date: 2002-12-04 21:00:22 -0600 (Wed, 04 Dec 2002)
> New Revision: 4002
>
> Modified:
> trunk/subversion/include/svn_auth.h
> trunk/subversion/include/svn_base64.h
> trunk/subversion/include/svn_client.h
> Log:
> * subversion/include/svn_base64.h
> add Doxygen markup to comments.
>
> * subversion/include/svn_client.h
> add Doxygen markup to comments.
>
> * subversion/include/svn_auth.h
> add Doxygen markup to comments.
[snip]
> -/* This is a structure which stores a filename and a hash of property
> - names and values. */
> -
> -typedef struct svn_client_proplist_item_s
> +/** This is a structure which stores a filename and a hash of property
> + * names and values.
> + */
> +typedef struct svn_client_proplist_item_t
> {
The python swig bindings failed to compile in rev 4002. I was confused for a
while since I had already successfully compiled them in rev 4001, and the log
message only mentioned changes to comments. But hey, there's code changes in
there!
The patch below gets the bindings to compile again. Note: I have no clue if
svn_client_proplist_item_t *should* be ignored.
Craig
Log:
Follow on to rev 4002
* subversion/bindings/swig/svn_client.i: svn_client_proplist_item_s renamed to
svn_client_proplist_item_t
Index: subversion/bindings/swig/svn_client.i
===================================================================
--- subversion/bindings/swig/svn_client.i (revision 4001)
+++ subversion/bindings/swig/svn_client.i (working copy)
@@ -27,7 +27,7 @@
/* -----------------------------------------------------------------------
don't wrap the following items
*/
-%ignore svn_client_proplist_item_s;
+%ignore svn_client_proplist_item_t;
/* -----------------------------------------------------------------------
these types (as 'type **') will always be an OUT param
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svn_client.i (was: svn commit: rev 4002 - trunk/subversion/include)
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Wednesday, December 4, 2002, at 11:50 PM, Craig Peterein wrote:
> [snip]
>
>> -/* This is a structure which stores a filename and a hash of property
>> - names and values. */
>> -
>> -typedef struct svn_client_proplist_item_s
>> +/** This is a structure which stores a filename and a hash of
>> property
>> + * names and values.
>> + */
>> +typedef struct svn_client_proplist_item_t
>> {
>
> The python swig bindings failed to compile in rev 4002. I was
> confused for a
> while since I had already successfully compiled them in rev 4001, and
> the log
> message only mentioned changes to comments. But hey, there's code
> changes in
> there!
>
> The patch below gets the bindings to compile again. Note: I have no
> clue if
> svn_client_proplist_item_t *should* be ignored.
oops, sorry about that. i had changed it because the generated docs
looked kind of inconsistent for no good reason with the old naming
scheme, and didn't think that type was actually used anywhere (since it
made it through a build). if nobody else gets a chance to commit this
i'll look at it tonight.
-garrett
--
garrett rooney Remember, any design flaw you're
rooneg@electricjellyfish.net sufficiently snide about becomes
http://electricjellyfish.net/ a feature. -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] svn_client.i (was: svn commit: rev 4002 - trunk/subversion/include)
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Wednesday, December 4, 2002, at 11:50 PM, Craig Peterein wrote:
> The patch below gets the bindings to compile again. Note: I have no
> clue if
> svn_client_proplist_item_t *should* be ignored.
this looks right to me (of course, i don't know much about swig, so
looking right to me doesn't mean much), so i committed it in rev 4017.
thanks,
-garrett
--
garrett rooney Remember, any design flaw you're
rooneg@electricjellyfish.net sufficiently snide about becomes
http://electricjellyfish.net/ a feature. -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org