You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/14 04:59:49 UTC

[GitHub] [skywalking] Liu-XinYuan opened a new pull request #4231: Optimize the speed of UI query interface based on elasticsearch storage

Liu-XinYuan opened a new pull request #4231: Optimize the speed of UI query interface based on elasticsearch storage
URL: https://github.com/apache/skywalking/pull/4231
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [x] Improve performance
   
   - Related issues
   #4194 
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage
URL: https://github.com/apache/skywalking/pull/4231#issuecomment-574018416
 
 
   > startSecondTB and endSecondTB are not real time.
   
   What do you mean not real? It is the exact time the client side query. And `Downsampling` is there too. What do you need? That is all. This is just an optimization inside the ES implementation, breaking all is not a good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] Liu-XinYuan commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage

Posted by GitBox <gi...@apache.org>.
Liu-XinYuan commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage
URL: https://github.com/apache/skywalking/pull/4231#issuecomment-574013298
 
 
   These two parameters are passed from the front end. The backend determines which indexes the query data is based on these two times

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] Liu-XinYuan closed pull request #4231: Optimize the speed of UI query interface based on elasticsearch storage

Posted by GitBox <gi...@apache.org>.
Liu-XinYuan closed pull request #4231: Optimize the speed of UI query interface based on elasticsearch storage
URL: https://github.com/apache/skywalking/pull/4231
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] Liu-XinYuan commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage

Posted by GitBox <gi...@apache.org>.
Liu-XinYuan commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage
URL: https://github.com/apache/skywalking/pull/4231#issuecomment-574017697
 
 
   - startSecondTB and endSecondTB are not real time. 
   - If I calculate the real time through these two parameters, I must get the parameter Step according to org.apache.skywalking.oap.server.core.query.DurationUtils and I must put this conversion in ElasticSearchClient. This will form a circular dependency between the library-client module and server-core

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] Liu-XinYuan commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage

Posted by GitBox <gi...@apache.org>.
Liu-XinYuan commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage
URL: https://github.com/apache/skywalking/pull/4231#issuecomment-574027390
 
 
   It makes sense that I can convert to real time by downsampling and bucket.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4231: Optimize the speed of UI query interface based on elasticsearch storage
URL: https://github.com/apache/skywalking/pull/4231#issuecomment-574013515
 
 
   You have the time-related parameter already. You should not break all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services