[GitHub] [lucene-solr] anshumg commented on a change in pull request #1058: SOLR-13972: Warn about insecure settings on startup

[GitBox <gi...@apache.org>]

anshumg commented on a change in pull request #1058: SOLR-13972: Warn about insecure settings on startup
URL: https://github.com/apache/lucene-solr/pull/1058#discussion_r355443164
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
 ##########
 @@ -657,6 +658,7 @@ public void load() {
 
     securityConfHandler = isZooKeeperAware() ? new SecurityConfHandlerZk(this) : new SecurityConfHandlerLocal(this);
     reloadSecurityProperties();
+    warnUsersIfSecurityDisabled();
 
 Review comment:
   `warnUsersOnInsecureSettings()` ? Security might be enabled in some way here but we still might prompt with a warning here e.g. auth enabled but TLS disabled. Don't want to be a pain with fixing the method names, but I think this change might make the code more readable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org