You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/11/05 03:03:16 UTC
[GitHub] [couchdb] jaydoane opened a new pull request #3817: Use `weatherreport_check_nodes_connected:check/1`
jaydoane opened a new pull request #3817:
URL: https://github.com/apache/couchdb/pull/3817
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
The arity 0 version does not exist.
Fixes dialyzer warning:
```
{warn_callgraph,{"src/weatherreport_node.erl",126},
{call_to_missing,[weatherreport_check_nodes_connected,check,
0]}}
```
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
```
make check
```
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [x] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane commented on pull request #3817: Use `weatherreport_check_nodes_connected:check/1`
Posted by GitBox <gi...@apache.org>.
jaydoane commented on pull request #3817:
URL: https://github.com/apache/couchdb/pull/3817#issuecomment-961980074
> +1
>
> Was wondering if we could wait until after we tag 3.2.1 to merge? Not big deal if we don't but in case we get a last minute -1, it would be nice to know we could still avoid branching.
Definitely will wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3817: Use `weatherreport_check_nodes_connected:check/1`
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3817:
URL: https://github.com/apache/couchdb/pull/3817#issuecomment-962400205
3.2.1 was tagged. Thank you for waiting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane merged pull request #3817: Use `weatherreport_check_nodes_connected:check/1`
Posted by GitBox <gi...@apache.org>.
jaydoane merged pull request #3817:
URL: https://github.com/apache/couchdb/pull/3817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane commented on pull request #3817: Use `weatherreport_check_nodes_connected:check/1`
Posted by GitBox <gi...@apache.org>.
jaydoane commented on pull request #3817:
URL: https://github.com/apache/couchdb/pull/3817#issuecomment-961980074
> +1
>
> Was wondering if we could wait until after we tag 3.2.1 to merge? Not big deal if we don't but in case we get a last minute -1, it would be nice to know we could still avoid branching.
Definitely will wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jaydoane commented on pull request #3817: Use `weatherreport_check_nodes_connected:check/1`
Posted by GitBox <gi...@apache.org>.
jaydoane commented on pull request #3817:
URL: https://github.com/apache/couchdb/pull/3817#issuecomment-961980074
> +1
>
> Was wondering if we could wait until after we tag 3.2.1 to merge? Not big deal if we don't but in case we get a last minute -1, it would be nice to know we could still avoid branching.
Definitely will wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org