You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2023/01/06 21:41:58 UTC

[GitHub] [trafficserver] bneradt commented on a diff in pull request #9286: Skip dns_host_down autest from 9.2.x branch

bneradt commented on code in PR #9286:
URL: https://github.com/apache/trafficserver/pull/9286#discussion_r1063826175


##########
tests/gold_tests/dns/dns_host_down.test.py:
##########
@@ -22,6 +22,10 @@
 Test.Summary = '''
 Verify ATS handles down origin servers with cached domain correctly.
 '''
+# This test is dependent on the new HostDB restructure that is not in 9.2.x.
+# The code is still applicable for 9.2.x but the autest created to show its
+# functionality is a workaround that only applies to 10-Dev.

Review Comment:
   I suggest a few tweaks to the second sentence:
   
   * `The code` -> `The production patch associated with this test`
   * `is a workaround` -> `relies upon the restructured HostDB's relationship with down nameservers`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org