[GitHub] [jmeter] FSchumacher commented on a diff in pull request #5870: Deadlock in testsuite

["FSchumacher (via GitHub)" <gi...@apache.org>]

FSchumacher commented on code in PR #5870:
URL: https://github.com/apache/jmeter/pull/5870#discussion_r1181123428


##########
src/core/src/main/java/org/apache/jmeter/gui/action/SelectTemplatesDialog.java:
##########
@@ -260,7 +261,9 @@ public void windowClosing(WindowEvent evt){
 
         this.pack();
         this.setMinimumSize(new Dimension(MINIMAL_BOX_WIDTH, MINIMAL_BOX_HEIGHT));
-        ComponentUtil.centerComponentInWindow(this, 50); // center position and 50% of screen size
+        SwingUtilities.invokeLater(() ->
+            ComponentUtil.centerComponentInWindow(this, 50) // center position and 50% of screen size
+        );
         populateTemplatePage();

Review Comment:
   Yes, I thought of that and I thought about moving it up in the code, as it is setText and getText, only. That should be safe, shouldn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org