You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/19 15:55:03 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #11062: [TVMScript] Allow parameters in @T.prim_func definition
Lunderberg opened a new pull request, #11062:
URL: https://github.com/apache/tvm/pull/11062
This extends the existing `@T.prim_func` decorator to accept a keyword-only argument `@T.prim_func(params=param_dict)`, defining a string to object mapping. This mapping can be used to refer to external parameters from within the `PrimFunc` definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg closed pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
Posted by GitBox <gi...@apache.org>.
Lunderberg closed pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
URL: https://github.com/apache/tvm/pull/11062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #11062:
URL: https://github.com/apache/tvm/pull/11062#issuecomment-1105276171
@junrushao1994 Not sure if you're asking me or @Hzfengsy on it, but I'm certainly okay with sharing. This was useful in some test cases I was sketching out, and figured it would be good to start a conversation on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11062:
URL: https://github.com/apache/tvm/pull/11062#issuecomment-1105447069
Oh sorry for the confusion! I was asking Siyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #11062:
URL: https://github.com/apache/tvm/pull/11062#issuecomment-1102833431
I was thinking of this as complementary to the existing `PrimFunc.specialize`. Where `specialize` can operate on existing `PrimFunc` objects, and can be used from C++, these parameters can only be used when generating a new `PrimFunc` object from Python.
The advantage of using the `prim_func` parameters is that they do not require adding the parameter to the `PrimFunc` arguments and do not require running through an additional transformation, making them easier to read when writing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11062:
URL: https://github.com/apache/tvm/pull/11062#issuecomment-1103267404
@Hzfengsy has some preliminary work on metaprogramming. Would you mind sharing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on PR #11062:
URL: https://github.com/apache/tvm/pull/11062#issuecomment-1106033237
Here is a related PR: https://github.com/apache/tvm/pull/11097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #11062: [TVMScript] Allow parameters in @T.prim_func definition
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #11062:
URL: https://github.com/apache/tvm/pull/11062#issuecomment-1109812458
Closing in favor of #11097, any deltas can be added in later PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org