[GitHub] [samza] Sanil15 commented on a change in pull request #1170: Samza-2330: Handle expired resource request for Container allocator when host affinity is disabled

[GitBox <gi...@apache.org>]

Sanil15 commented on a change in pull request #1170: Samza-2330: Handle expired resource request for Container allocator when host affinity is disabled	
URL: https://github.com/apache/samza/pull/1170#discussion_r330338638
 
 

 ##########
 File path: samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerProcessManager.java
 ##########
 @@ -71,7 +71,7 @@
       put("cluster-manager.container.retry.count", "1");
       put("cluster-manager.container.retry.window.ms", "1999999999");
       put("cluster-manager.allocator.sleep.ms", "1");
-      put("cluster-manager.container.request.timeout.ms", "2");
+      put("cluster-manager.container.request.timeout.ms", "100");
 
 Review comment:
   Before this patch this config was no op since expiry did not apply to ContainerAllocator without host affinity. Hence I changed this config to fix failing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services