You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by rdowner <gi...@git.apache.org> on 2017/06/07 10:15:57 UTC
[GitHub] brooklyn-server pull request #721: DynamicFabric: add support for firstMembe...
GitHub user rdowner opened a pull request:
https://github.com/apache/brooklyn-server/pull/721
DynamicFabric: add support for firstMemberSpec
Just like DynamicCluster does.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdowner/brooklyn-server dynamicfabric-changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/721.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #721
----
commit cd29cdfb94f6e058ca9dd19b3636d03a8db52740
Author: Richard Downer <ri...@apache.org>
Date: 2017-06-07T10:13:17Z
DynamicFabric: add support for firstMemberSpec
Just like DynamicCluster does.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #721: DynamicFabric: add support for firstMemberSpec
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/721
@rdowner agree with @drigodwin - code looks good, but would be good to have a test similar to `DynamicClusterTest.testDifferentFirstMemberSpec` (see
https://github.com/apache/brooklyn-server/blob/master/core/src/test/java/org/apache/brooklyn/entity/group/DynamicClusterTest.java#L975)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #721: DynamicFabric: add support for firstMemberSpec
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the issue:
https://github.com/apache/brooklyn-server/pull/721
Thanks for the comments. Sorry for the delay so far, mainly due to vacation. Having a few problems with writing a good test but will get this PR updated as soon as I can.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #721: DynamicFabric: add support for firstMembe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/721
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #721: DynamicFabric: add support for firstMemberSpec
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the issue:
https://github.com/apache/brooklyn-server/pull/721
Ready for re-review @drigodwin @aledsage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---