You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/02/01 04:29:39 UTC
Re: Review Request: Resource Monitoring 10: Implemented OSX resource usage
collection.
> On Jan. 31, 2013, 8:24 p.m., Vinod Kone wrote:
> > src/slave/process_based_isolation_module.cpp, line 25
> > <https://reviews.apache.org/r/9147/diff/1/?file=253223#file253223line25>
> >
> > s/ProcessBasedIsolationModule::// ?
Used // For proc_pidinfo.
> On Jan. 31, 2013, 8:24 p.m., Vinod Kone wrote:
> > src/slave/process_based_isolation_module.cpp, line 333
> > <https://reviews.apache.org/r/9147/diff/1/?file=253223#file253223line333>
> >
> > Why not use our Duration abstraction?
Nice, thanks!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9147/#review15974
-----------------------------------------------------------
On Jan. 30, 2013, 4:11 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9147/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2013, 4:11 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Implements process based isolation resource collection for OSX.
>
>
> This addresses bug MESOS-324.
> https://issues.apache.org/jira/browse/MESOS-324
>
>
> Diffs
> -----
>
> src/slave/process_based_isolation_module.cpp 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5
>
> Diff: https://reviews.apache.org/r/9147/diff/
>
>
> Testing
> -------
>
> End-to-end tests via webui.
>
>
> Thanks,
>
> Ben Mahler
>
>