You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Alexander Klimetschek (JIRA)" <ji...@apache.org> on 2007/05/09 18:08:15 UTC

[jira] Created: (COCOON-2062) forms/ajax manifest.js miss include dojo.require("dojo.ns")

forms/ajax manifest.js miss include dojo.require("dojo.ns")
-----------------------------------------------------------

                 Key: COCOON-2062
                 URL: https://issues.apache.org/jira/browse/COCOON-2062
             Project: Cocoon
          Issue Type: Bug
          Components: Blocks: Ajax, Blocks: Forms
    Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
            Reporter: Alexander Klimetschek


cocoon-ajax-impl and cocoon-forms-impl are missing a dojo.require("dojo.ns") statement at the beginning because they access dojo.registerNamespace() which comes from that package. (No patch for this, since it's a one-liner)

Sidenote: A workaround by manually adding this require in a script or other js file before manifest.js are accessed does noes work when you have djConfig.debugAtAllCosts enabled, since then dojo parses the js files for dojo.require() with a regexp (to avoid eval and adding all js files as script elements to the browser so that they appear correctly in your favourite javascript debugger). A missing require in that file will get the dependency order wrong.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (COCOON-2062) forms/ajax manifest.js miss include dojo.require("dojo.ns")

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski closed COCOON-2062.
----------------------------------------

    Resolution: Fixed

Committed in r555108.
Closing the issue, reopen if something is wrong.

> forms/ajax manifest.js miss include dojo.require("dojo.ns")
> -----------------------------------------------------------
>
>                 Key: COCOON-2062
>                 URL: https://issues.apache.org/jira/browse/COCOON-2062
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
>            Reporter: Alexander Klimetschek
>            Assignee: Grzegorz Kossakowski
>
> cocoon-ajax-impl and cocoon-forms-impl are missing a dojo.require("dojo.ns") statement at the beginning because they access dojo.registerNamespace() which comes from that package. (No patch for this, since it's a one-liner)
> Sidenote: A workaround by manually adding this require in a script or other js file before manifest.js are accessed does noes work when you have djConfig.debugAtAllCosts enabled, since then dojo parses the js files for dojo.require() with a regexp (to avoid eval and adding all js files as script elements to the browser so that they appear correctly in your favourite javascript debugger). A missing require in that file will get the dependency order wrong.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (COCOON-2062) forms/ajax manifest.js miss include dojo.require("dojo.ns")

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski updated COCOON-2062:
-----------------------------------------

    Assignee: Grzegorz Kossakowski

Alexander, thanks for spotting this issue.

I understand the problem but I'm not sure when to add this one line. Since you already know it there is no point to repeat the effort of figuring it out myself.

Could you provide a patch? :)

> forms/ajax manifest.js miss include dojo.require("dojo.ns")
> -----------------------------------------------------------
>
>                 Key: COCOON-2062
>                 URL: https://issues.apache.org/jira/browse/COCOON-2062
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
>            Reporter: Alexander Klimetschek
>            Assignee: Grzegorz Kossakowski
>
> cocoon-ajax-impl and cocoon-forms-impl are missing a dojo.require("dojo.ns") statement at the beginning because they access dojo.registerNamespace() which comes from that package. (No patch for this, since it's a one-liner)
> Sidenote: A workaround by manually adding this require in a script or other js file before manifest.js are accessed does noes work when you have djConfig.debugAtAllCosts enabled, since then dojo parses the js files for dojo.require() with a regexp (to avoid eval and adding all js files as script elements to the browser so that they appear correctly in your favourite javascript debugger). A missing require in that file will get the dependency order wrong.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (COCOON-2062) forms/ajax manifest.js miss include dojo.require("dojo.ns")

Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510972 ] 

Alexander Klimetschek commented on COCOON-2062:
-----------------------------------------------

Well, it's simple: add 

dojo.require("dojo.ns")

at the top (just below the dojo.provide statement) of these two files:

blocks/cocoon-ajax/cocoon-ajax-impl/src/main/resources/org/apache/cocoon/ajax/resources/manifest.js
blocks/cocoon-forms/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/manifest.js


> forms/ajax manifest.js miss include dojo.require("dojo.ns")
> -----------------------------------------------------------
>
>                 Key: COCOON-2062
>                 URL: https://issues.apache.org/jira/browse/COCOON-2062
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN)
>            Reporter: Alexander Klimetschek
>            Assignee: Grzegorz Kossakowski
>
> cocoon-ajax-impl and cocoon-forms-impl are missing a dojo.require("dojo.ns") statement at the beginning because they access dojo.registerNamespace() which comes from that package. (No patch for this, since it's a one-liner)
> Sidenote: A workaround by manually adding this require in a script or other js file before manifest.js are accessed does noes work when you have djConfig.debugAtAllCosts enabled, since then dojo parses the js files for dojo.require() with a regexp (to avoid eval and adding all js files as script elements to the browser so that they appear correctly in your favourite javascript debugger). A missing require in that file will get the dependency order wrong.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.