You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2022/04/05 16:50:00 UTC
[jira] [Resolved] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Miller resolved LUCENE-10467.
----------------------------------
Fix Version/s: 9.2
Resolution: Fixed
Merged and backported. Thanks [~yutinggan]!
> Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0
> ------------------------------------------------------------------------------
>
> Key: LUCENE-10467
> URL: https://issues.apache.org/jira/browse/LUCENE-10467
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Yuting Gan
> Priority: Minor
> Fix For: 9.2
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently, there are different behaviors from subclass that implements and overrides getAllDims and getTopChildren when passing in an invalid TopN parameter (topN <= 0). Some overridden implementations throw a NullPointerException, some throw an IllegalArgumentException, and others throw no exception.
> It would provide a better user experience by consistently throwing an IllegalArgumentException when requesting topN <= 0 for these two functionalities across all implementations.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org