You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/13 07:24:21 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #677: fix: remove the step of deleting httpbinsvc
tao12345666333 commented on a change in pull request #677:
URL: https://github.com/apache/apisix-ingress-controller/pull/677#discussion_r707049277
##########
File path: test/e2e/ingress/resourcepushing.go
##########
@@ -216,7 +216,7 @@ spec:
s.NewAPISIXClient().GET("/ip").WithHeader("Host", "httpbin.com").Expect().Status(http.StatusNotFound)
s.NewAPISIXClient().GET("/ip").WithHeader("Host", "httpbin.com").WithHeader("X-Foo", "barbaz").Expect().Status(http.StatusOK)
// remove k8s service first
- assert.Nil(ginkgo.GinkgoT(), s.DeleteHTTPBINService())
+ //assert.Nil(ginkgo.GinkgoT(), s.DeleteHTTPBINService())
Review comment:
```suggestion
// assert.Nil(ginkgo.GinkgoT(), s.DeleteHTTPBINService())
```
##########
File path: test/e2e/ingress/resourcepushing.go
##########
@@ -216,7 +216,7 @@ spec:
s.NewAPISIXClient().GET("/ip").WithHeader("Host", "httpbin.com").Expect().Status(http.StatusNotFound)
s.NewAPISIXClient().GET("/ip").WithHeader("Host", "httpbin.com").WithHeader("X-Foo", "barbaz").Expect().Status(http.StatusOK)
// remove k8s service first
- assert.Nil(ginkgo.GinkgoT(), s.DeleteHTTPBINService())
+ //assert.Nil(ginkgo.GinkgoT(), s.DeleteHTTPBINService())
Review comment:
just need change the format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org