[GitHub] [arrow-rs] viirya commented on a change in pull request #1334: `ArrowArray::try_from_raw` should not assume the pointers are from Arc

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #1334:
URL: https://github.com/apache/arrow-rs/pull/1334#discussion_r816221790



##########
File path: arrow/src/ffi.rs
##########
@@ -721,9 +721,11 @@ impl ArrowArray {
                     .to_string(),
             ));
         };
+        let ffi_array = (*array).clone();

Review comment:
       > The clone here seems to just be a clone of the FFI_ArrowArray struct itself (which is some ints and pointers) which seems reasonable enough to me.
   
   That's right.

##########
File path: arrow/src/ffi.rs
##########
@@ -721,9 +721,11 @@ impl ArrowArray {
                     .to_string(),
             ));
         };
+        let ffi_array = (*array).clone();

Review comment:
       Thanks @alamb 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org