You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by tn...@apache.org on 2013/04/27 14:40:03 UTC
svn commit: r1476564 -
/commons/proper/collections/trunk/findbugs-exclude-filter.xml
Author: tn
Date: Sat Apr 27 12:40:02 2013
New Revision: 1476564
URL: http://svn.apache.org/r1476564
Log:
Add findbugs exclude filters for ObjectArrayIterator and UnmodifiableBidiMap.
Modified:
commons/proper/collections/trunk/findbugs-exclude-filter.xml
Modified: commons/proper/collections/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/findbugs-exclude-filter.xml?rev=1476564&r1=1476563&r2=1476564&view=diff
==============================================================================
--- commons/proper/collections/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/collections/trunk/findbugs-exclude-filter.xml Sat Apr 27 12:40:02 2013
@@ -52,6 +52,12 @@
<Bug pattern="EQ_UNUSUAL" />
</Match>
+ <!-- Access to field inverse is 100% synchronized, findbugs may be inaccurate for this check -->
+ <Match>
+ <Class name="org.apache.commons.collections4.bidimap.UnmodifiableBidiMap" />
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
+
<!-- The compare method in ComparatorChain has to handle a corner-case for Integer.MIN_VALUE -->
<Match>
<Class name="org.apache.commons.collections4.comparators.ComparatorChain" />
@@ -59,4 +65,13 @@
<Bug pattern="RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE" />
</Match>
+ <!-- The ObjectArrayIterator does iterate over an array, thus this we do not want to copy it -->
+ <Match>
+ <Class name="org.apache.commons.collections4.iterators.ObjectArrayIterator" />
+ <Or>
+ <Bug pattern="EI_EXPOSE_REP" />
+ <Bug pattern="EI_EXPOSE_REP2" />
+ </Or>
+ </Match>
+
</FindBugsFilter>