You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2015/02/26 02:40:29 UTC
Review Request 31451: Port thermos observer to the path detector
interface
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Zameer Manji.
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
-------
This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
Diffs
-----
src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
src/main/python/apache/thermos/observer/detector.py PRE-CREATION
src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
src/test/python/apache/thermos/observer/BUILD PRE-CREATION
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
-------
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Zameer Manji <zm...@apache.org>.
> On Feb. 25, 2015, 5:44 p.m., Brian Wickman wrote:
> > src/main/python/apache/thermos/observer/task_observer.py, line 592
> > <https://reviews.apache.org/r/31451/diff/1/?file=877050#file877050line592>
> >
> > fix this.
>
> Brian Wickman wrote:
> You should definitely be concerned about the current state of the observer. I've started a big refactor and some of the progress can be found here: https://github.com/apache/incubator-aurora/compare/master...wickman:wickman/AURORA-1026 It will substantially improve the test coverage for this code.
Would it be too much to ask to land the refactor in pieces first before this change?
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74184
-----------------------------------------------------------
On Feb. 25, 2015, 5:50 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:50 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
> On Feb. 26, 2015, 1:44 a.m., Brian Wickman wrote:
> > src/main/python/apache/thermos/observer/task_observer.py, line 592
> > <https://reviews.apache.org/r/31451/diff/1/?file=877050#file877050line592>
> >
> > fix this.
>
> Brian Wickman wrote:
> You should definitely be concerned about the current state of the observer. I've started a big refactor and some of the progress can be found here: https://github.com/apache/incubator-aurora/compare/master...wickman:wickman/AURORA-1026 It will substantially improve the test coverage for this code.
>
> Zameer Manji wrote:
> Would it be too much to ask to land the refactor in pieces first before this change?
yes.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74184
-----------------------------------------------------------
On Feb. 26, 2015, 1:50 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 1:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
> On Feb. 26, 2015, 1:44 a.m., Brian Wickman wrote:
> > src/main/python/apache/thermos/observer/task_observer.py, line 592
> > <https://reviews.apache.org/r/31451/diff/1/?file=877050#file877050line592>
> >
> > fix this.
You should definitely be concerned about the current state of the observer. I've started a big refactor and some of the progress can be found here: https://github.com/apache/incubator-aurora/compare/master...wickman:wickman/AURORA-1026 It will substantially improve the test coverage for this code.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74184
-----------------------------------------------------------
On Feb. 26, 2015, 1:50 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 1:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74184
-----------------------------------------------------------
src/main/python/apache/thermos/observer/task_observer.py
<https://reviews.apache.org/r/31451/#comment120713>
fix this.
- Brian Wickman
On Feb. 26, 2015, 1:40 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 1:40 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74354
-----------------------------------------------------------
Master (36af017) is red with this patch.
./build-support/jenkins/build.sh
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.log
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.log-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.process
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.process-0.3.0-py2.7-nspkg.pth
Running setup.py install for gitdb
building 'gitdb._perf' extension
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c gitdb/_fun.c -o build/temp.linux-x86_64-2.7/gitdb/_fun.o
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c gitdb/_delta_apply.c -o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o
x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -D_FORTIFY_SOURCE=2 -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/gitdb/_fun.o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o -o build/lib.linux-x86_64-2.7/gitdb/_perf.so
Running setup.py install for twitter.common.app
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.app-0.3.0-py2.7-nspkg.pth
Running setup.py install for GitPython
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/setuptools/dist.py:292: UserWarning: The version specified ('0.3.2 RC1') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
"details." % self.metadata.version
Running setup.py install for pep8
Installing pep8 script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for pyflakes
Installing pyflakes script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for twitter.checkstyle
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.checkstyle-0.1.0-py2.7-nspkg.pth
Installing twitterstyle script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0 twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0
F401:ERROR src/main/python/apache/aurora/executor/common/resource_manager.py:027 'TaskPath' imported but unused
|from apache.thermos.common.path import TaskPath
F401:ERROR src/main/python/apache/aurora/executor/thermos_task_runner.py:034 'TaskPath' imported but unused
|from apache.thermos.common.path import TaskPath
F401:ERROR src/main/python/apache/thermos/observer/task_observer.py:033 'TaskDetector' imported but unused
|from apache.thermos.monitoring.detector import TaskDetector
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 26, 2015, 7:46 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 7:46 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74345
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 26, 2015, 11:46 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 11:46 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74384
-----------------------------------------------------------
Master (db99eb0) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
src.test.python.apache.thermos.bin.test_thermos ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.common.test_planner ..... SUCCESS
src.test.python.apache.thermos.common.test_task_planner ..... SUCCESS
src.test.python.apache.thermos.config.test_schema ..... SUCCESS
src.test.python.apache.thermos.core.test_angry ..... SUCCESS
src.test.python.apache.thermos.core.test_ephemerals ..... SUCCESS
src.test.python.apache.thermos.core.test_failing_runner ..... SUCCESS
src.test.python.apache.thermos.core.test_failure_limit ..... SUCCESS
src.test.python.apache.thermos.core.test_finalization ..... SUCCESS
src.test.python.apache.thermos.core.test_helper ..... SUCCESS
src.test.python.apache.thermos.core.test_process ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.core.test_staged_kill ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_detector ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_garbage ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_resource ..... FAILURE
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 26, 2015, 10:43 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 10:43 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74606
-----------------------------------------------------------
Master (388a5b3) is red with this patch.
./build-support/jenkins/build.sh
:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865: error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
^
symbol: class IJobKey
location: class QuotaManagerImplTest
1 error
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 41.054 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 27, 2015, 10 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 10 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Joe Smith <ya...@gmail.com>.
> On March 1, 2015, 12:47 p.m., Joe Smith wrote:
> > src/test/python/apache/thermos/observer/test_detector.py, line 76
> > <https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line76>
> >
> > I think it's worthy to make this (and others) explicitly:
> >
> > assert on_active.mock_calls == [mock.call(TASK1[0], TASK1[1]]
>
> Brian Wickman wrote:
> on_active.assert_called_once_with(X) is the same as assert on_active.mock_calls == [mock.call(X)], right?
Hm.. not sure what I was going for here, maybe I missed the *? Anyways, you're right and +1.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74709
-----------------------------------------------------------
On March 3, 2015, 2:58 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 2:58 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD b8dd28c3e64248d0181ad606d4c6de5d915ac706
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 6cc928edc60d7a0f3b0e668edf68eb81b49cdb22
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
> On March 1, 2015, 8:47 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/executor/common/resource_manager.py, line 96
> > <https://reviews.apache.org/r/31451/diff/6/?file=880982#file880982line96>
> >
> > Why is this moving to kwargs? (My normal assumption is to stick with actual arguments)
this is mostly so we don't have to duplicate all the options for TaskResourceMonitor. These options are really just around for mocking.
> On March 1, 2015, 8:47 p.m., Joe Smith wrote:
> > src/main/python/apache/thermos/observer/detector.py, line 8
> > <https://reviews.apache.org/r/31451/diff/6/?file=880992#file880992line8>
> >
> > You think something like this might help for a docstring?
> >
> > ```
> > class ObserverTaskDetector(object):
> > """The canonical way to watch (and be notified) of tasks transitioning state from active -> finished -> removed."""
> > ```
"""ObserverTaskDetector turns on-disk thermos task transitions into callback events."""
> On March 1, 2015, 8:47 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 79
> > <https://reviews.apache.org/r/31451/diff/6/?file=880998#file880998line79>
> >
> > Maybe add a TODO not to write to the filesystem?
No. It is an integration test.
> On March 1, 2015, 8:47 p.m., Joe Smith wrote:
> > src/test/python/apache/thermos/observer/test_detector.py, line 1
> > <https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line1>
> >
> > add apache copywrite header?
fixed
> On March 1, 2015, 8:47 p.m., Joe Smith wrote:
> > src/test/python/apache/thermos/observer/test_detector.py, line 70
> > <https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line70>
> >
> > putting this in a `setUp` method would remove the need for remembering `on_finished.reset_mock()` right?
this would be true if each contextmanager block could live in its own test_... function, but because the state of the ObserverTaskDetector needs to be carried from context to context (e.g. active_tasks=TASK1, then finished_tasks=TASK1 to ensure that on_finished is called, etc) we can't tear down all test state, and instead need to reset the mocks.
> On March 1, 2015, 8:47 p.m., Joe Smith wrote:
> > src/test/python/apache/thermos/observer/test_detector.py, line 76
> > <https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line76>
> >
> > I think it's worthy to make this (and others) explicitly:
> >
> > assert on_active.mock_calls == [mock.call(TASK1[0], TASK1[1]]
on_active.assert_called_once_with(X) is the same as assert on_active.mock_calls == [mock.call(X)], right?
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74709
-----------------------------------------------------------
On Feb. 27, 2015, 11:36 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 11:36 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74709
-----------------------------------------------------------
src/main/python/apache/aurora/executor/common/resource_manager.py
<https://reviews.apache.org/r/31451/#comment121377>
Why is this moving to kwargs? (My normal assumption is to stick with actual arguments)
src/main/python/apache/thermos/observer/detector.py
<https://reviews.apache.org/r/31451/#comment121380>
You think something like this might help for a docstring?
```
class ObserverTaskDetector(object):
"""The canonical way to watch (and be notified) of tasks transitioning state from active -> finished -> removed."""
```
src/main/python/apache/thermos/observer/task_observer.py
<https://reviews.apache.org/r/31451/#comment121381>
New logic read much more easily to me, thanks!
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
<https://reviews.apache.org/r/31451/#comment121382>
Maybe add a TODO not to write to the filesystem?
src/test/python/apache/thermos/observer/test_detector.py
<https://reviews.apache.org/r/31451/#comment121383>
add apache copywrite header?
src/test/python/apache/thermos/observer/test_detector.py
<https://reviews.apache.org/r/31451/#comment121379>
putting this in a `setUp` method would remove the need for remembering `on_finished.reset_mock()` right?
src/test/python/apache/thermos/observer/test_detector.py
<https://reviews.apache.org/r/31451/#comment121378>
I think it's worthy to make this (and others) explicitly:
assert on_active.mock_calls == [mock.call(TASK1[0], TASK1[1]]
- Joe Smith
On Feb. 27, 2015, 3:36 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 3:36 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review75074
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On March 3, 2015, 2:58 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 2:58 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD b8dd28c3e64248d0181ad606d4c6de5d915ac706
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 6cc928edc60d7a0f3b0e668edf68eb81b49cdb22
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review75082
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 3, 2015, 2:58 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 2:58 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD b8dd28c3e64248d0181ad606d4c6de5d915ac706
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 6cc928edc60d7a0f3b0e668edf68eb81b49cdb22
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review75078
-----------------------------------------------------------
Ship it!
Master (2bf03dc) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 3, 2015, 10:58 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 10:58 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD b8dd28c3e64248d0181ad606d4c6de5d915ac706
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 6cc928edc60d7a0f3b0e668edf68eb81b49cdb22
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------
(Updated March 3, 2015, 10:58 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Feedbackses
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
-------
This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
src/main/python/apache/thermos/observer/detector.py PRE-CREATION
src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
src/test/python/apache/aurora/executor/BUILD b8dd28c3e64248d0181ad606d4c6de5d915ac706
src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
src/test/python/apache/aurora/executor/test_thermos_executor.py 6cc928edc60d7a0f3b0e668edf68eb81b49cdb22
src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
src/test/python/apache/thermos/observer/BUILD PRE-CREATION
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
-------
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74633
-----------------------------------------------------------
Ship it!
Master (4cca6a6) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 27, 2015, 11:36 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 11:36 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
> src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
> src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
> src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
> src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 11:36 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Merge master build fix.
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
-------
This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
src/main/python/apache/thermos/observer/detector.py PRE-CREATION
src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
src/test/python/apache/thermos/observer/BUILD PRE-CREATION
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
-------
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 10 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Add missing test dependency that was causing --no-fast builds to break.
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
-------
This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
src/main/python/apache/thermos/observer/detector.py PRE-CREATION
src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
src/test/python/apache/thermos/observer/BUILD PRE-CREATION
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
-------
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 10:43 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Holy smokes, there was some test coverage. Fix the tests.
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
-------
This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/BUILD 8cef41d04aff9edc7da7053e05341274a9bd0834
src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
src/main/python/apache/thermos/observer/detector.py PRE-CREATION
src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
src/test/python/apache/aurora/executor/BUILD 2ee9b1233e9db47455ddccccffbc48691d379222
src/test/python/apache/aurora/executor/common/BUILD 7b73f693d161cfd205435e4acb398f553b92389f
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py 8f288f6115ab52265dfaffffda3f41d81271c55a
src/test/python/apache/aurora/executor/test_thermos_executor.py 8dbfb1db5eb7a6548820ff7cf82a9c7092f61d28
src/test/python/apache/thermos/bin/test_thermos.py 2d9d33397ae01b31ab011d958f5457311ef7ef20
src/test/python/apache/thermos/core/test_staged_kill.py faa23ae6afcaa443d23c65e5e027902961a0e52b
src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634
src/test/python/apache/thermos/monitoring/test_resource.py 52d813946379bdc70c40ad079c74b54f60bd4b41
src/test/python/apache/thermos/observer/BUILD PRE-CREATION
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
-------
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 7:46 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Remove tbds
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
-------
This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
src/main/python/apache/thermos/observer/detector.py PRE-CREATION
src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
src/test/python/apache/thermos/observer/BUILD PRE-CREATION
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
-------
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74188
-----------------------------------------------------------
Master (9442e08) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS
src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.kill_manager ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_executor ..... FAILURE
src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 26, 2015, 1:50 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 1:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
> On Feb. 26, 2015, 4:25 a.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/bin/thermos.py, line 289
> > <https://reviews.apache.org/r/31451/diff/2/?file=877122#file877122line289>
> >
> > How is this change related to the observer change?
I was testing the observer by doing local thermos runs, and this command was broken, so I fixed it.
> On Feb. 26, 2015, 4:25 a.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/observer/detector.py, line 32
> > <https://reviews.apache.org/r/31451/diff/2/?file=877130#file877130line32>
> >
> > Can you please confirm if this property is only used in testing?
It is not only used by tests. The next observer CL has a component called the TaskDatabase that uses it.
> On Feb. 26, 2015, 4:25 a.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/observer/detector.py, line 78
> > <https://reviews.apache.org/r/31451/diff/2/?file=877130#file877130line78>
> >
> > Please put a TODO(wickman) instead of a TBD
Hrm, this code is already janky. I will make it more concise and send back a second diff on this review.
> On Feb. 26, 2015, 4:25 a.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/observer/task_observer.py, line 147
> > <https://reviews.apache.org/r/31451/diff/2/?file=877133#file877133line147>
> >
> > Why is the detector protected witha lock but none of the callbacks are?
> >
> > I think either the detector should have an internal lock to prevent concurrent refreshes or the lock here should also be used to protect the callbacks that are passed in.
refreshes only happen in the run() thread. the callbacks are guaranteed to only be invoked by .refresh(), therefore protecting it with the lock is fine. the main need for the lock is for the Lockable.sync read methods (which will be going away in the next review.)
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74206
-----------------------------------------------------------
On Feb. 26, 2015, 1:50 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 1:50 a.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74206
-----------------------------------------------------------
src/main/python/apache/thermos/bin/thermos.py
<https://reviews.apache.org/r/31451/#comment120725>
How is this change related to the observer change?
src/main/python/apache/thermos/observer/detector.py
<https://reviews.apache.org/r/31451/#comment120728>
Can you please confirm if this property is only used in testing?
src/main/python/apache/thermos/observer/detector.py
<https://reviews.apache.org/r/31451/#comment120726>
Please put a TODO(wickman) instead of a TBD
src/main/python/apache/thermos/observer/task_observer.py
<https://reviews.apache.org/r/31451/#comment120727>
Why is the detector protected witha lock but none of the callbacks are?
I think either the detector should have an internal lock to prevent concurrent refreshes or the lock here should also be used to protect the callbacks that are passed in.
- Zameer Manji
On Feb. 25, 2015, 5:50 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31451/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:50 p.m.)
>
>
> Review request for Aurora, Joe Smith and Zameer Manji.
>
>
> Bugs: AURORA-1026
> https://issues.apache.org/jira/browse/AURORA-1026
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
> src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
> src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
> src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
> src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
> src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
> src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
> src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
> src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
> src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
> src/main/python/apache/thermos/observer/detector.py PRE-CREATION
> src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
> src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
> src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
> src/test/python/apache/thermos/observer/BUILD PRE-CREATION
> src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31451/diff/
>
>
> Testing
> -------
>
> Manually launched observer and ran some thermos tasks.
> +
> mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 31451: Port thermos observer to the path detector
interface
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 1:50 a.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Changes
-------
Fix missing reference to pathspec.
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
-------
This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a
src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1
src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda
src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2
src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7
src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8
src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04
src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f
src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138
src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5
src/main/python/apache/thermos/observer/detector.py PRE-CREATION
src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381
src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04
src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886
src/test/python/apache/thermos/observer/BUILD PRE-CREATION
src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION
Diff: https://reviews.apache.org/r/31451/diff/
Testing
-------
Manually launched observer and ran some thermos tasks.
+
mba=aurora=; ./pants test src/test/python/apache/thermos/observer/::
Thanks,
Brian Wickman