[GitHub] [nifi] mcgilman commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…

[GitBox <gi...@apache.org>]

mcgilman commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#issuecomment-509724215
 
 
   @markap14 Thanks for the update. I've left some follow up comments in my previous feedback. A couple of other items:
   
   - Asked earlier but did not see any response... What are your thoughts on automatically setting the parameter context on newly created Process Groups based on the currently bound parameter context in the parent Process Group? Since parameters are not inherited, this could be a convenient feature if users would expect this behavior. There is a downside to consider that changing the bound parameter context would be cumbersome but this downside would exist regardless if this convenience were implemented.
   - When updating a Process Group to bind a Parameter Context, I am able to even if I do not have access to that Process Group. I think we need to update this and perform this check.
   - When updating a Process Group to bind a Parameter Context, I am able to even if that Parameter Context has affected components that I do not have access to. I think we need to update this and perform these checks.
   - When updating a Process Group to unbind a Parameter Context, I am able to even if I do not have access to that Process Group. This check is questionable in my opinion. We do require permissions to a referenced Controller Service when it is being dereferenced. So I could see adding that check here too however with Controller Services they can be affected by the components referencing them. This is not really the case here but I still think it seems reasonable to add.
   - When updating a Process Group to unbind a Parameter Context, I am able to even if that Parameter Context has affected components that I do not have access to. I think we need to update this and perform these checks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services