You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 12:49:55 UTC

[GitHub] [arrow] pitrou opened a new pull request #8493: ARROW-10318: [C++] Use pimpl idiom in CSV parser

pitrou opened a new pull request #8493:
URL: https://github.com/apache/arrow/pull/8493


   Hide more implementation details from `parser.h`.
   
   Interestingly, this increases performance on the CSV parser micro-benchmarks (at least here with clang 10.0 on Ubuntu 20.04).
   * before:
   ```
   -------------------------------------------------------------------------------
   Benchmark                     Time             CPU   Iterations UserCounters...
   -------------------------------------------------------------------------------
   ParseCSVQuotedBlock       95316 ns        95299 ns        29615 bytes_per_second=655.817M/s
   ParseCSVEscapedBlock      93352 ns        93339 ns        30059 bytes_per_second=630.202M/s
   ```
   * after:
   ```
   ParseCSVQuotedBlock       75507 ns        75497 ns        37173 bytes_per_second=827.833M/s
   ParseCSVEscapedBlock      70170 ns        70157 ns        43528 bytes_per_second=838.448M/s
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8493: ARROW-10318: [C++] Use pimpl idiom in CSV parser

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712843737


   https://issues.apache.org/jira/browse/ARROW-10318


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou edited a comment on pull request #8493: ARROW-10318: [C++] Use pimpl idiom in CSV parser

Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712844395


   (TODO: improve parser benchmarks a bit) -> done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] bkietz commented on pull request #8493: ARROW-10318: [C++] Use pimpl idiom in CSV parser

Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712971264


   CI failures are unrelated, merging


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #8493: ARROW-10318: [C++] Use pimpl idiom in CSV parser

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712844395


   TODO: improve parser benchmarks a bit


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] bkietz closed pull request #8493: ARROW-10318: [C++] Use pimpl idiom in CSV parser

Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #8493:
URL: https://github.com/apache/arrow/pull/8493


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org