You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/06/28 20:30:07 UTC
[GitHub] [camel] ppalaga opened a new pull request, #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
ppalaga opened a new pull request, #10539:
URL: https://github.com/apache/camel/pull/10539
https://issues.apache.org/jira/browse/CAMEL-19560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617726425
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 2 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617915618
13c1a2e: one more attempt to make `CurrentSpanTest.testContextDoesNotLeak()` more robust
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1612187216
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 1 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1618158892
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 2 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1612062431
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1629086252
If you add
```
@AfterEach
void noLeakingContext() {
Assertions.assertSame(Context.root(), Context.current(), "There must be no leaking span after test");
}
```
into `CamelOpenTelemetryTestSupport` and `CamelMicrometerObservationTestSupport` the `MulticastRouteTest` will start to fail sometimes. Apparently something is wrong in the Camel Tracing module that doesn't clear scopes properly. I'm still looking into that - it's very difficult to replicate and fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1618244097
https://github.com/apache/camel/pull/10567 shows that org.apache.camel.opentelemetry.CurrentSpanTest.testContextDoesNotLeak() and org.apache.camel.observation.CurrentSpanTest.testContextDoesNotLeak fail regardless of the management changes in this PR.
I am not sure what is the problem I have filed https://issues.apache.org/jira/browse/CAMEL-19569 Would you perhaps like to have a look @marcingrzejszczak ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617587439
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 1 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617559032
90a4298: rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1620369059
When has this started failing? Apparently there's a flakey test (every now and then trace id after a couple of retries is being reused instead of recreated) and I can reproduce it sometimes on my laptop. I don't recall such things happen when I make the feature so I'm curious what has changed in the meantime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617587459
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617962336
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 2 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617962381
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1612187227
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1612094686
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 1 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1612094711
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617704286
981e24c: Made the CurrentSpanTest more robust also in the observability component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617958502
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1620665987
I am not aware of any substantial change but my stand of knowledge might be rather inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617726461
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1617958450
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 3 | 3 | 2 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] marcingrzejszczak commented on pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #10539:
URL: https://github.com/apache/camel/pull/10539#issuecomment-1618247171
Sure, I'll look into that tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga merged pull request #10539: CAMEL-19560 - Manage micrometer artifacts to build and test with a single deterministic set of versions
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #10539:
URL: https://github.com/apache/camel/pull/10539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org