[jira] [Created] (YUNIKORN-2683) Unnecessary error is logged when resource usage is increased

["Peter Bacsko (Jira)" <ji...@apache.org>]

Peter Bacsko created YUNIKORN-2683:
--------------------------------------

             Summary: Unnecessary error is logged when resource usage is increased
                 Key: YUNIKORN-2683
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2683
             Project: Apache YuniKorn
          Issue Type: Bug
          Components: core - scheduler
            Reporter: Peter Bacsko


The refactored code in YUNIKORN-2542 contains an unnecessary warning message:

{noformat}
	appGroup := userTracker.getGroupForApp(applicationID)
	log.Log(log.SchedUGM).Debug("Increasing resource usage for user",
		zap.String("user", user.User),
		zap.String("queue path", queuePath),
		zap.String("application", applicationID),
		zap.String("group", appGroup),
		zap.Stringer("resource", usage))
	groupTracker := m.GetGroupTracker(appGroup)
	if groupTracker == nil {
		log.Log(log.SchedUGM).Error("group tracker should be available in groupTrackers map",
		zap.String("application", applicationID),
		zap.String("group", appGroup))
		return
	}
...
{noformat}

We don't always have a {{groupTracker}}. The previous code simply called {{increaseTrackedResource()}} on an empty tracker:

{noformat}
func (ut *UserTracker) increaseTrackedResource(queuePath string, applicationID string, usage *resources.Resource) {
	ut.Lock()
	defer ut.Unlock()
	ut.events.sendIncResourceUsageForUser(ut.userName, queuePath, usage)
	hierarchy := strings.Split(queuePath, configs.DOT)
	ut.queueTracker.increaseTrackedResource(hierarchy, applicationID, user, usage)
	gt := ut.appGroupTrackers[applicationID]
	log.Log(log.SchedUGM).Debug("Increasing resource usage for group",
		zap.String("group", gt.getName()),
		zap.Strings("queue path", hierarchy),
		zap.String("application", applicationID),
		zap.Stringer("resource", usage))
	gt.increaseTrackedResource(queuePath, applicationID, usage, ut.userName) <- can be null
}
{noformat}





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org