You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/03/31 00:08:27 UTC
[jira] Created: (THRIFT-745) Builder-style constructors for servers
Builder-style constructors for servers
--------------------------------------
Key: THRIFT-745
URL: https://issues.apache.org/jira/browse/THRIFT-745
Project: Thrift
Issue Type: New Feature
Components: Library (Java)
Affects Versions: 0.3
Reporter: Bryan Duxbury
Fix For: 0.3
It's really hard to instantiate Java Thrift servers - they have a ton of params that you may or may not want to use. Rather than having 6 different constructor overloads, I think we should support builder-style constructors. This would have the side benefit of letting us get rid of the Options class that a few of the servers support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-745) Builder-style constructors for servers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-745:
---------------------------------
Fix Version/s: 0.5
> Builder-style constructors for servers
> --------------------------------------
>
> Key: THRIFT-745
> URL: https://issues.apache.org/jira/browse/THRIFT-745
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Fix For: 0.5
>
>
> It's really hard to instantiate Java Thrift servers - they have a ton of params that you may or may not want to use. Rather than having 6 different constructor overloads, I think we should support builder-style constructors. This would have the side benefit of letting us get rid of the Options class that a few of the servers support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-745) Make it easier to instantiate servers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-745.
--------------------------------
Resolution: Fixed
> Make it easier to instantiate servers
> -------------------------------------
>
> Key: THRIFT-745
> URL: https://issues.apache.org/jira/browse/THRIFT-745
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.6
>
> Attachments: thrift-745.patch
>
>
> It's really hard to instantiate Java Thrift servers - they have a ton of params that you may or may not want to use. Rather than having 6 different constructor overloads, I think we should support builder-style constructors. This would have the side benefit of letting us get rid of the Options class that a few of the servers support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-745) Builder-style constructors for
servers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-745:
------------------------------------
Assignee: Bryan Duxbury
> Builder-style constructors for servers
> --------------------------------------
>
> Key: THRIFT-745
> URL: https://issues.apache.org/jira/browse/THRIFT-745
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.6
>
> Attachments: thrift-745.patch
>
>
> It's really hard to instantiate Java Thrift servers - they have a ton of params that you may or may not want to use. Rather than having 6 different constructor overloads, I think we should support builder-style constructors. This would have the side benefit of letting us get rid of the Options class that a few of the servers support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-745) Make it easier to instantiate servers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-745:
---------------------------------
Summary: Make it easier to instantiate servers (was: Builder-style constructors for servers)
> Make it easier to instantiate servers
> -------------------------------------
>
> Key: THRIFT-745
> URL: https://issues.apache.org/jira/browse/THRIFT-745
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.6
>
> Attachments: thrift-745.patch
>
>
> It's really hard to instantiate Java Thrift servers - they have a ton of params that you may or may not want to use. Rather than having 6 different constructor overloads, I think we should support builder-style constructors. This would have the side benefit of letting us get rid of the Options class that a few of the servers support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-745) Builder-style constructors for servers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-745:
---------------------------------
Attachment: thrift-745.patch
This patch removes the superfluous constructors and replaces them all with a single constructor that takes a class-specific "Args" structure. This makes it really easy to instantiate servers.
I'm planning to commit this shortly, but I'd love some after-the-fact review.
> Builder-style constructors for servers
> --------------------------------------
>
> Key: THRIFT-745
> URL: https://issues.apache.org/jira/browse/THRIFT-745
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Fix For: 0.6
>
> Attachments: thrift-745.patch
>
>
> It's really hard to instantiate Java Thrift servers - they have a ton of params that you may or may not want to use. Rather than having 6 different constructor overloads, I think we should support builder-style constructors. This would have the side benefit of letting us get rid of the Options class that a few of the servers support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-745) Builder-style constructors for servers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-745:
---------------------------------
Fix Version/s: 0.6
(was: 0.5)
> Builder-style constructors for servers
> --------------------------------------
>
> Key: THRIFT-745
> URL: https://issues.apache.org/jira/browse/THRIFT-745
> Project: Thrift
> Issue Type: New Feature
> Components: Java - Library
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Fix For: 0.6
>
>
> It's really hard to instantiate Java Thrift servers - they have a ton of params that you may or may not want to use. Rather than having 6 different constructor overloads, I think we should support builder-style constructors. This would have the side benefit of letting us get rid of the Options class that a few of the servers support.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.