You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Erik Huelsmann <eh...@gmail.com> on 2006/10/01 09:06:00 UTC

Re: svn trunk r21723: FAIL (x86-macosx-gnu shared ra_local fsfs)

On 9/30/06, buildbot@mobsol.be <bu...@mobsol.be> wrote:
> Full details are available at:
> http://www.mobsol.be/buildbot/x86-macosx-gnu%2520shared%2520ra_local%2520fsfs/builds/1136
>
> Author list: dionisos

It turns out that special_tests 7 (merge link into file) creates a
broken symlink, so that the link could be stat()ed, but the file can't
be opened for reading (not that it makes sense to do so with a
symlink).

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn trunk r21723: FAIL (x86-macosx-gnu shared ra_local fsfs)

Posted by Erik Huelsmann <eh...@gmail.com>.
On 10/1/06, Lieven Govaerts <sv...@mobsol.be> wrote:
> Erik Huelsmann wrote:
> > On 9/30/06, buildbot@mobsol.be <bu...@mobsol.be> wrote:
> >> Full details are available at:
> >> http://www.mobsol.be/buildbot/x86-macosx-gnu%2520shared%2520ra_local%2520fsfs/builds/1136
> >>
> >>
> >> Author list: dionisos
> >
> > It turns out that special_tests 7 (merge link into file) creates a
> > broken symlink, so that the link could be stat()ed, but the file can't
> > be opened for reading (not that it makes sense to do so with a
> > symlink).
> Hm, we need more info.
>
> What's incorrect about the symlink?
>
> Do we need to fix the test to create a correct symlink? Or should the
> code be changed to not open symlinks for reading?

See r21725 :-)

But, we may need tests with broken and valid symlinks which create
both categories on purpose. I think this test wasn't creating the
brokenness on purpose.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn trunk r21723: FAIL (x86-macosx-gnu shared ra_local fsfs)

Posted by Lieven Govaerts <sv...@mobsol.be>.
Erik Huelsmann wrote:
> On 9/30/06, buildbot@mobsol.be <bu...@mobsol.be> wrote:
>> Full details are available at:
>> http://www.mobsol.be/buildbot/x86-macosx-gnu%2520shared%2520ra_local%2520fsfs/builds/1136 
>>
>>
>> Author list: dionisos
>
> It turns out that special_tests 7 (merge link into file) creates a
> broken symlink, so that the link could be stat()ed, but the file can't
> be opened for reading (not that it makes sense to do so with a
> symlink).
Hm, we need more info.

What's incorrect about the symlink?

Do we need to fix the test to create a correct symlink? Or should the 
code be changed to not open symlinks for reading?

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org